From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753343AbaI1Olc (ORCPT ); Sun, 28 Sep 2014 10:41:32 -0400 Received: from mail-qc0-f181.google.com ([209.85.216.181]:58457 "EHLO mail-qc0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750901AbaI1Ola (ORCPT ); Sun, 28 Sep 2014 10:41:30 -0400 Date: Sun, 28 Sep 2014 10:41:23 -0400 From: Tejun Heo To: "Luis R. Rodriguez" Cc: gregkh@linuxfoundation.org, dmitry.torokhov@gmail.com, tiwai@suse.de, arjan@linux.intel.com, teg@jklm.no, rmilasan@suse.com, werner@suse.com, oleg@redhat.com, hare@suse.com, bpoirier@suse.de, santosh@chelsio.com, pmladek@suse.cz, dbueso@suse.com, mcgrof@suse.com, linux-kernel@vger.kernel.org, Doug Thompson , Borislav Petkov , Mauro Carvalho Chehab , linux-edac@vger.kernel.org Subject: Re: [PATCH v1 3/5] amd64_edac: enforce synchronous probe Message-ID: <20140928144123.GB5023@mtj.dyndns.org> References: <1411768637-6809-1-git-send-email-mcgrof@do-not-panic.com> <1411768637-6809-4-git-send-email-mcgrof@do-not-panic.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1411768637-6809-4-git-send-email-mcgrof@do-not-panic.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Sep 26, 2014 at 02:57:15PM -0700, Luis R. Rodriguez wrote: ... > [ 14.414746] [] ? dump_stack+0x41/0x51 > [ 14.414790] [] ? warn_slowpath_common+0x72/0x90 > [ 14.414834] [] ? warn_slowpath_fmt+0x47/0x50 > [ 14.414880] [] ? printk+0x4f/0x51 > [ 14.414921] [] ? kernfs_remove_by_name_ns+0x83/0x90 > [ 14.415000] [] ? driver_sysfs_remove+0x1d/0x40 > [ 14.415046] [] ? driver_probe_device+0x1d5/0x250 > [ 14.415099] [] ? __driver_attach+0x7b/0x80 > [ 14.415149] [] ? __device_attach+0x40/0x40 > [ 14.415204] [] ? bus_for_each_dev+0x53/0x90 > [ 14.415254] [] ? driver_attach_workfn+0x13/0x80 > [ 14.415298] [] ? process_one_work+0x143/0x3c0 > [ 14.415342] [] ? worker_thread+0x114/0x480 > [ 14.415384] [] ? rescuer_thread+0x2b0/0x2b0 > [ 14.415427] [] ? kthread+0xc1/0xe0 > [ 14.415468] [] ? kthread_create_on_node+0x170/0x170 > [ 14.415511] [] ? ret_from_fork+0x7c/0xb0 > [ 14.415554] [] ? kthread_create_on_node+0x170/0x170 Do you have CONFIG_FRAME_POINTER turned off? Probe failure itself aside, the above looks like a bug in really_probe()'s error path. It looks like it can try to remove sysfs directory that it hasn't added yet. Thanks. -- tejun