From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753878AbaI2POV (ORCPT ); Mon, 29 Sep 2014 11:14:21 -0400 Received: from mailout2.w2.samsung.com ([211.189.100.12]:32396 "EHLO usmailout2.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751521AbaI2POU (ORCPT ); Mon, 29 Sep 2014 11:14:20 -0400 X-AuditID: cbfec372-b7f2f6d0000052b3-fe-5429774ac774 Date: Mon, 29 Sep 2014 12:14:12 -0300 From: Mauro Carvalho Chehab To: Arnd Bergmann Cc: linux-media@vger.kernel.org, Akihiro Tsukada , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH] [media] pt3: remove bogus module_is_live() check Message-id: <20140929121412.66f2dd67.m.chehab@samsung.com> In-reply-to: <6460819.BmnhuA22YH@wuerfel> References: <6460819.BmnhuA22YH@wuerfel> X-Mailer: Claws Mail 3.10.1 (GTK+ 2.24.24; x86_64-redhat-linux-gnu) MIME-version: 1.0 Content-type: text/plain; charset=US-ASCII Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrNLMWRmVeSWpSXmKPExsVy+t/hIF2vcs0Qg7t3+Sz+TjrGbrHp8TVW i8u75rBZ9GzYymqx5uxeRgdWj9+/JjF67Jx1l91j85J6j8+b5AJYorhsUlJzMstSi/TtErgy /s/7w1Iwi79i++4GlgbGZzxdjBwcEgImErPWO3UxcgKZYhIX7q1n62Lk4hASWMIosX7GclYI p5FJ4vCZLkaQKhYBVYkfDzezgdhsAkYSrxpbWEFsEQFFiakvnjGD2MwCnYwSC7ZGgtjCAq4S F37/YQVZxitgJTFnYQhImFNAU2J770ywciEBDYm9V1YyQ9zjLDH/czZImFdAUOLH5HssEBO1 JDZva2KFsOUlNq95yzyBUWAWkrJZSMpmISlbwMi8ilG0tDi5oDgpPddQrzgxt7g0L10vOT93 EyMkgIt2MD7bYHWIUYCDUYmHl2OFRogQa2JZcWXuIUYJDmYlEV67FM0QId6UxMqq1KL8+KLS nNTiQ4xMHJxSDYzV8646xe1a/Vot3cfwoYfcU0u3jScV22Y59H/9OGdPq9mTSfOubBG9qyAh bHrkuF8By7z/j9Lit3jErr0n3+HVa9n2Uefsp2KR+Q855PbuUysqPfLDaZ8Qr6heQ8G27X5c HeK8cZWpe+Os06a1xlfHLz1aJPJd5rnk6pqt27TnseU59N06v0eJpTgj0VCLuag4EQBHqFcY PgIAAA== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Arnd, Em Mon, 29 Sep 2014 16:28:55 +0200 Arnd Bergmann escreveu: > The new pt3 driver checks the module reference for presence > before dropping it, which fails to compile when modules > are disabled: > > media/pci/pt3/pt3.c: In function 'pt3_attach_fe': > media/pci/pt3/pt3.c:433:6: error: implicit declaration of function 'module_is_live' [-Werror=implicit-function-declaration] > module_is_live(pt3->adaps[i]->i2c_tuner->dev.driver->owner)) > > As far as I can tell however, this check is not needed at all, because > the module will not go away as long as pt3 is holding a reference on > it. Also the previous check for NULL pointer is not needed at all, > because module_put has the same check. > > Signed-off-by: Arnd Bergmann Thanks for this patch. Antti was quicker than you ;) I merged the patch on my tree yesterday. It should be popping up on the tomorrow's -next (I think that sfr didn't release one today). > > diff --git a/drivers/media/pci/pt3/pt3.c b/drivers/media/pci/pt3/pt3.c > index 90f86ce7a001..39305f07dc2e 100644 > --- a/drivers/media/pci/pt3/pt3.c > +++ b/drivers/media/pci/pt3/pt3.c > @@ -429,14 +429,10 @@ static int pt3_attach_fe(struct pt3_board *pt3, int i) > > err_tuner: > i2c_unregister_device(pt3->adaps[i]->i2c_tuner); > - if (pt3->adaps[i]->i2c_tuner->dev.driver->owner && > - module_is_live(pt3->adaps[i]->i2c_tuner->dev.driver->owner)) > - module_put(pt3->adaps[i]->i2c_tuner->dev.driver->owner); > + module_put(pt3->adaps[i]->i2c_tuner->dev.driver->owner); > err_demod: > i2c_unregister_device(pt3->adaps[i]->i2c_demod); > - if (pt3->adaps[i]->i2c_demod->dev.driver->owner && > - module_is_live(pt3->adaps[i]->i2c_demod->dev.driver->owner)) > - module_put(pt3->adaps[i]->i2c_demod->dev.driver->owner); > + module_put(pt3->adaps[i]->i2c_demod->dev.driver->owner); > return ret; > } > >