From: Mark Brown <broonie@kernel.org>
To: Dan Murphy <dmurphy@ti.com>
Cc: gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org,
linux-omap@vger.kernel.org
Subject: Re: [PATCH] regmap: Allow read_reg_mask to be 0
Date: Tue, 30 Sep 2014 18:25:43 +0100 [thread overview]
Message-ID: <20140930172543.GG4273@sirena.org.uk> (raw)
In-Reply-To: <1412093220-24690-1-git-send-email-dmurphy@ti.com>
[-- Attachment #1: Type: text/plain, Size: 560 bytes --]
On Tue, Sep 30, 2014 at 11:07:00AM -0500, Dan Murphy wrote:
> - if (config->read_flag_mask || config->write_flag_mask) {
> + if (config->read_flag_mask == REGMAP_NO_READ_MASK)
> + map->read_flag_mask = 0x00;
> + else if (config->read_flag_mask)
This breaks the symmetry in handling of read and write masks which isn't
great, please make the equivalent update for the write mask too.
> +#define REGMAP_NO_READ_MASK 0xff
An actual out of band value might be preferable here though that'd
involve changing the type and more checking so perhaps inessential.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
next prev parent reply other threads:[~2014-09-30 17:26 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-30 16:07 Dan Murphy
2014-09-30 17:25 ` Mark Brown [this message]
2014-09-30 20:19 ` Dan Murphy
2014-09-30 20:20 ` Dan Murphy
2014-09-30 20:39 ` Dan Murphy
2014-09-30 21:03 ` Lars-Peter Clausen
2014-09-30 21:18 ` Dan Murphy
2014-09-30 21:29 ` Lars-Peter Clausen
2014-10-01 11:15 ` Mark Brown
2014-10-01 11:39 ` Dan Murphy
2014-10-01 16:30 ` Lars-Peter Clausen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140930172543.GG4273@sirena.org.uk \
--to=broonie@kernel.org \
--cc=dmurphy@ti.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®