From: Mark Brown <broonie@kernel.org>
To: "Opensource [James Seong-Won Ban]" <James.Ban.opensource@diasemi.com>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
Support Opensource <Support.Opensource@diasemi.com>,
LKML <linux-kernel@vger.kernel.org>,
David Dajun Chen <david.chen@diasemi.com>
Subject: Re: [PATCH V1] regulator: DA9211 : Fix a bug in update of mask bit
Date: Wed, 1 Oct 2014 12:45:24 +0100 [thread overview]
Message-ID: <20141001114524.GU4273@sirena.org.uk> (raw)
In-Reply-To: <0ACAE736BB7A70499F1D8D5E6AC1854C01AC2AF92C@SW-EX-MBX01.diasemi.com>
[-- Attachment #1: Type: text/plain, Size: 788 bytes --]
On Wed, Oct 01, 2014 at 01:02:27AM +0000, Opensource [James Seong-Won Ban] wrote:
> > Applied, but please try to make sure that your changelogs are more
> > descriptive - what is the bug? Please also use subject lines matching
> > the style for the subsystem.
> The proper operation of mask bit should be set as '0' for enabling the interrupt.
> The result of mask operation at previous code was the same to new one.
> But the meaning in the previous code was to set mask bit as '1'.
Right, the point is that this information should've gone in the
changelog - please bear this in mind for future patches.
> What is subject line you said?
> If you give me an example, it would be very helpful to me.
git shortlog drivers/regulator. The capitalisation and extra spaces are
both off.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
prev parent reply other threads:[~2014-10-01 11:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-29 7:59 James Ban
2014-09-30 12:45 ` Mark Brown
2014-10-01 1:02 ` Opensource [James Seong-Won Ban]
2014-10-01 11:45 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141001114524.GU4273@sirena.org.uk \
--to=broonie@kernel.org \
--cc=James.Ban.opensource@diasemi.com \
--cc=Support.Opensource@diasemi.com \
--cc=david.chen@diasemi.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®