From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751497AbaJAMs2 (ORCPT ); Wed, 1 Oct 2014 08:48:28 -0400 Received: from bombadil.infradead.org ([198.137.202.9]:49466 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751053AbaJAMs1 (ORCPT ); Wed, 1 Oct 2014 08:48:27 -0400 Date: Wed, 1 Oct 2014 05:48:25 -0700 From: Christoph Hellwig To: Ard Biesheuvel Cc: Nicolas Pitre , "linux-kernel@vger.kernel.org" , Nicholas Mc Guire Subject: Re: aesbs-core.S_shipped? Message-ID: <20141001124825.GA31067@infradead.org> References: <20140930155033.GA21640@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Sep 30, 2014 at 06:26:19PM +0200, Ard Biesheuvel wrote: > > can you explain me why arch/arm/crypto/aesbs-core.S_shipped > > is a _shipped file? I can't find any reason why it should be, > > it's a normal .S file in every way as far as I can tell. > > It is generated by aesbs-core.pl, and Russell preferred including it > as a _shipped file rather than generating it from the perl script on > each build. (Note that the Perl script is kept in sync with OpenSSL, > i.e., the goal is to be able to generate the kernel .S and the OpenSSL > userland .S from the same script) Thanks for the explanation. Can you update the script so that it inserts a comment explaining how the file was generated into it? Also to satisfy the GPL you need to include a copy of aesbs-core.pl in the kernel tree. I only did a quick find -name aesbs-core.pl that didn't find any results, so if it's named slightly differently feel free to discard this second comment.