From: Tobias Klauser <tklauser@distanz.ch>
To: Joe Perches <joe@perches.com>
Cc: Mark Einon <mark.einon@gmail.com>,
davem@davemloft.net, gregkh@linuxfoundation.org,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH net-next] et131x: Add PCIe gigabit ethernet driver et131x to drivers/net
Date: Wed, 1 Oct 2014 16:14:49 +0200 [thread overview]
Message-ID: <20141001141449.GI3279@distanz.ch> (raw)
In-Reply-To: <1412171027.3247.6.camel@joe-AO725>
On 2014-10-01 at 15:43:47 +0200, Joe Perches <joe@perches.com> wrote:
> On Wed, 2014-10-01 at 14:45 +0200, Tobias Klauser wrote:
> > On 2014-09-30 at 23:29:46 +0200, Mark Einon <mark.einon@gmail.com> wrote:
> > > This adds the ethernet driver for Agere et131x devices to
> > > drivers/net/ethernet.
> []
> > > diff --git a/drivers/net/ethernet/agere/et131x.c b/drivers/net/ethernet/agere/et131x.c
> []
> > > + rc = pci_enable_device(pdev);
> > > + if (rc < 0) {
> > > + dev_err(&pdev->dev, "pci_enable_device() failed\n");
> > > + goto out;
> >
> > Nit: Just return rc here.
>
> I don't think it matters at all.
Combined with my second remark this change makes the `out' label
unnecessary. If Mark decides to keep the goto here, at least the
position of the label should be changed to the end of the function, to
remain predictable and avoid jumping back.
next prev parent reply other threads:[~2014-10-01 14:14 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-30 21:29 Mark Einon
2014-10-01 12:45 ` Tobias Klauser
2014-10-01 13:43 ` Joe Perches
2014-10-01 14:14 ` Tobias Klauser [this message]
2014-10-01 19:02 ` Mark Einon
2014-10-03 19:25 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141001141449.GI3279@distanz.ch \
--to=tklauser@distanz.ch \
--cc=davem@davemloft.net \
--cc=gregkh@linuxfoundation.org \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.einon@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®