Re: [PATCH v3 0/4] Allow xHCI drivers to be built as separate modules

[Greg Kroah-Hartman <gregkh@linuxfoundation.org>]

On Thu, Oct 02, 2014 at 07:31:03PM +0300, Mathias Nyman wrote:
> On 09/09/2014 05:27 PM, Mathias Nyman wrote:
> > On 09/03/2014 10:51 PM, Andrew Bresticker wrote:
> >> Mathias,
> >>
> >> On Tue, Aug 19, 2014 at 10:01 AM, Andrew Bresticker
> >> <abrestic@chromium.org> wrote:
> >>> It was suggested in the review of the Tegra xHCI driver [1] that we
> >>> allow xHCI drivers to be built as individual modules (like EHCI) instead
> >>> of building them all into the single xhci-hcd module as they are today.
> >>>
> >>> Patches 1-3 prepare for making the xHCI PCI and platform drivers able
> >>> to be built as individual modules and patch 4 actually creates the 3
> >>> separate modules (core, platform, PCI).
> >>>
> >>> Based on 3.17-rc1.
> >>>
> >>> Changes from v2:
> >>>  - fixed typo in xhci_register_plat
> >>>  - exported another symbol needed by xhci-pci module
> >>> Changes from v1:
> >>>  - rebased on changes introduced by xhci-rcar driver
> >>>
> >>> [1] http://patchwork.ozlabs.org/patch/361265/
> >>>
> >>> Andrew Bresticker (4):
> >>>   xhci: Introduce xhci_init_driver()
> >>>   xhci: Check for XHCI_COMP_MODE_QUIRK when disabling D3cold
> >>>   xhci: Export symbols used by host-controller drivers
> >>>   xhci: Allow xHCI drivers to be built as separate modules
> >>
> >> Any thoughts/comments on this series?
> >>
> >>
> > 
> > Sorry about the delay.
> > When I start looking at this I always get interrupted by some fire that needs to be put out.
> > 
> > I still need some more time to go through it
> > 
> > -Mathias
> > 
> > --
> >
> 
> Ok, finally found the time to look through it. Sorry about the long wait
> 
> The whole series look good, and its now more in line with how ehci does things (like using *hci_init_driver())
> 
> Series still apply nicely on usb-next.
> 
> Greg, any chance this still can get to your usb-next and to the 3.18 merge window?
> Tegra developers seem eager to get it in, and I feel bad for not reviewing it earlier. 

They aren't in my patch queue anymore, so please send them, with your
signed-off-by, and I will try to get them in.

greg k-h