From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754649AbaJCUBB (ORCPT ); Fri, 3 Oct 2014 16:01:01 -0400 Received: from shards.monkeyblade.net ([149.20.54.216]:59012 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751343AbaJCUA7 (ORCPT ); Fri, 3 Oct 2014 16:00:59 -0400 Date: Fri, 03 Oct 2014 13:03:05 -0700 (PDT) Message-Id: <20141003.130305.2216770567363258603.davem@davemloft.net> To: mwelling@ieee.org Cc: tony@atomide.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] drivers:ethernet:davinci_emac.c:Fixes flaw in mac address handling. From: David Miller In-Reply-To: <1412217125-11057-1-git-send-email-mwelling@ieee.org> References: <1412217125-11057-1-git-send-email-mwelling@ieee.org> X-Mailer: Mew version 6.4 on Emacs 23.4 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.7 (shards.monkeyblade.net [149.20.54.216]); Fri, 03 Oct 2014 13:00:59 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Michael Welling Date: Wed, 1 Oct 2014 21:32:05 -0500 > The code currently checks the mac_addr variable that is clearly > zero'd out during allocation. > > Further code is added to bring the mac_addr from the partial pdata. > > Signed-off-by: Michael Welling I don't see anyone specifying a MAC address in the partial pdata, so better to just delete that field. Even if people did, I am not so sure that the partial pdata should unconditionally trump an OF provided MAC address.