mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Alexander Gordeev <agordeev@redhat.com>
To: linux-kernel@vger.kernel.org
Cc: linux-ide@vger.kernel.org
Subject: [PATCH 7/5] AHCI: Do not acquire ata_host::lock from single IRQ handler
Date: Mon, 6 Oct 2014 16:26:35 +0100	[thread overview]
Message-ID: <20141006152635.GB18209@agordeev.usersys.redhat.com> (raw)
In-Reply-To: <cover.1412007152.git.agordeev@redhat.com>

There is no need to acquire ata_host::lock spinlock from
hardware context single IRQ interrupt handler since the
handler does not access host data that could be altered
by concurrent processors.

Signed-off-by: Alexander Gordeev <agordeev@redhat.com>
Cc: linux-ide@vger.kernel.org
---
 drivers/ata/libahci.c | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/drivers/ata/libahci.c b/drivers/ata/libahci.c
index 3ce3d23..5eb61c9 100644
--- a/drivers/ata/libahci.c
+++ b/drivers/ata/libahci.c
@@ -1875,8 +1875,6 @@ static irqreturn_t ahci_single_irq_intr(int irq, void *dev_instance)
 
 	irq_masked = irq_stat & hpriv->port_map;
 
-	spin_lock(&host->lock);
-
 	for (i = 0; i < host->n_ports; i++) {
 		struct ata_port *ap;
 
@@ -1908,8 +1906,6 @@ static irqreturn_t ahci_single_irq_intr(int irq, void *dev_instance)
 	 */
 	writel(irq_stat, mmio + HOST_IRQ_STAT);
 
-	spin_unlock(&host->lock);
-
 	VPRINTK("EXIT\n");
 
 	return handled ? IRQ_WAKE_THREAD : IRQ_NONE;
-- 
1.8.3.1

-- 
Regards,
Alexander Gordeev
agordeev@redhat.com

  parent reply	other threads:[~2014-10-06 15:17 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-29 16:25 [PATCH v5 0/5] AHCI: Optimize interrupt processing in multi-MSI mode Alexander Gordeev
2014-09-29 16:25 ` [PATCH v5 1/5] AHCI: Pass SCSI host template as arg to ahci_host_activate() Alexander Gordeev
2014-09-29 16:25 ` [PATCH v5 2/5] AHCI: Move ahci_host_activate() function to libahci.c Alexander Gordeev
2014-09-29 16:25 ` [PATCH v5 3/5] AHCI: Move host activation code into ahci_host_activate() Alexander Gordeev
2014-09-29 16:26 ` [PATCH v5 4/5] AHCI: Make few function names more descriptive Alexander Gordeev
2014-09-29 16:26 ` [PATCH v5 5/5] AHCI: Do not read HOST_IRQ_STAT reg in multi-MSI mode Alexander Gordeev
2014-10-06 15:24 ` [PATCH 6/5] AHCI: Optimize single IRQ interrupt processing Alexander Gordeev
2014-10-06 15:26 ` Alexander Gordeev [this message]
2014-10-06 15:45 ` [PATCH v5 0/5] AHCI: Optimize interrupt processing in multi-MSI mode Tejun Heo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141006152635.GB18209@agordeev.usersys.redhat.com \
    --to=agordeev@redhat.com \
    --cc=linux-ide@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®