From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Jean Pihet <jean.pihet@linaro.org>
Cc: Borislav Petkov <bp@alien8.de>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Fu Wei <fu.wei@linaro.org>, Robert Richter <rric@kernel.org>,
Jiri Olsa <jolsa@redhat.com>, David Ahern <dsahern@gmail.com>,
Ingo Molnar <mingo@kernel.org>
Subject: [PATCH 1/1] rasd: Use perf_evlist__open() instead of open coded
Date: Mon, 6 Oct 2014 18:26:06 -0300 [thread overview]
Message-ID: <20141006212606.GF14113@kernel.org> (raw)
In-Reply-To: <CAFrcx1kufO2yj7--UiL841Yp5Es5=WqjL__Yzg=-+nPV5XoohA@mail.gmail.com>
Heya, please check if this is OK.
This was while looking the set of methods used by rasd, trying to reduce
it to the bare minimum.
Perhaps even that cpu_map__new() one can be ditched, leaving to use the
default of a NULL cpumap that will end up being one with -1, i.e. all
cpus.
- Arnaldo
>From 8dc34bd2824c7843182f4fc6deabaf573e42e806 Mon Sep 17 00:00:00 2001
From: Arnaldo Carvalho de Melo <acme@redhat.com>
Date: Mon, 6 Oct 2014 15:43:42 -0300
Subject: [PATCH] rasd: Use perf_evlist__open() instead of open coded
equivalent
Cc: Borislav Petkov <bp@suse.de>
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
src/rasd.c | 10 +++-------
1 file changed, 3 insertions(+), 7 deletions(-)
diff --git a/src/rasd.c b/src/rasd.c
index 06ccdcdd9d56..fb33fca131fa 100644
--- a/src/rasd.c
+++ b/src/rasd.c
@@ -241,7 +241,6 @@ static void daemonize(void)
int main()
{
- struct perf_evsel *c;
struct thread_map *threads;
struct cpu_map *cpus;
int i;
@@ -278,12 +277,9 @@ int main()
perf_evlist__set_maps(evlist, cpus, threads);
/* Open events */
- evlist__for_each(evlist, c) {
- /* On all online cpus by default, system wide tracing */
- if (perf_evsel__open(c, evlist->cpus, NULL) < 0)
- err("opening tracepoint, are you root?");
- }
- perf_evlist__set_id_pos(evlist);
+ /* On all online cpus by default, system wide tracing */
+ if (perf_evlist__open(evlist) < 0)
+ err("opening tracepoint, are you root?");
/* mmap buffers */
if (perf_evlist__mmap(evlist, 4 /* opts->mmap_pages */, false) < 0)
--
1.9.3
next prev parent reply other threads:[~2014-10-06 21:26 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-30 9:06 perf & rasd integration plan Jean Pihet
2014-09-30 13:24 ` Arnaldo Carvalho de Melo
2014-10-05 17:48 ` Borislav Petkov
2014-10-05 18:24 ` Jiri Olsa
2014-10-05 18:45 ` Borislav Petkov
2014-10-05 19:24 ` Chuck Ebbert
2014-10-05 19:28 ` Jiri Olsa
2014-10-06 6:53 ` Jean Pihet
2014-10-08 6:59 ` Jiri Olsa
2014-10-06 9:07 ` Robert Richter
2014-10-06 13:44 ` Jean Pihet
2014-10-06 14:58 ` Arnaldo Carvalho de Melo
2014-10-06 15:01 ` Borislav Petkov
2014-10-06 15:08 ` Arnaldo Carvalho de Melo
2014-10-06 15:16 ` Borislav Petkov
2014-10-06 15:02 ` Jean Pihet
2014-10-06 15:07 ` Arnaldo Carvalho de Melo
2014-10-06 15:16 ` Borislav Petkov
2014-10-06 19:12 ` Arnaldo Carvalho de Melo
2014-10-06 19:53 ` Borislav Petkov
2014-10-06 21:22 ` Arnaldo Carvalho de Melo
2014-10-07 11:23 ` Borislav Petkov
2014-10-07 13:40 ` Arnaldo Carvalho de Melo
2014-10-07 13:49 ` Borislav Petkov
2014-10-07 13:55 ` Arnaldo Carvalho de Melo
2014-10-07 14:02 ` Borislav Petkov
2014-10-07 14:13 ` Arnaldo Carvalho de Melo
2014-10-06 21:26 ` Arnaldo Carvalho de Melo [this message]
2014-10-07 8:45 ` [PATCH 1/1] rasd: Use perf_evlist__open() instead of open coded Jean Pihet
2014-10-07 13:32 ` Arnaldo Carvalho de Melo
2014-10-07 14:04 ` Borislav Petkov
2014-10-07 14:17 ` Arnaldo Carvalho de Melo
2014-10-10 20:07 ` Arnaldo Carvalho de Melo
2014-10-10 20:28 ` Borislav Petkov
2014-10-10 20:41 ` Arnaldo Carvalho de Melo
2014-10-10 20:44 ` Borislav Petkov
2014-10-13 7:29 ` Jean Pihet
2014-10-14 13:56 ` Jiri Olsa
2014-10-14 14:02 ` Arnaldo Carvalho de Melo
2014-10-14 14:22 ` Jiri Olsa
2014-10-14 15:17 ` Borislav Petkov
2014-10-14 15:20 ` Jean Pihet
2014-10-14 14:19 ` David Ahern
2014-10-14 17:09 ` Arnaldo Carvalho de Melo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141006212606.GF14113@kernel.org \
--to=acme@kernel.org \
--cc=bp@alien8.de \
--cc=dsahern@gmail.com \
--cc=fu.wei@linaro.org \
--cc=jean.pihet@linaro.org \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=rric@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome