From: Mark Brown <broonie@kernel.org>
To: Ben Zhang <benzh@chromium.org>
Cc: alsa-devel@alsa-project.org, Bard Liao <bardliao@realtek.com>,
Oder Chiou <oder_chiou@realtek.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3] ASoC: rt5677: Add ACPI device probing
Date: Tue, 7 Oct 2014 20:12:12 +0100 [thread overview]
Message-ID: <20141007191212.GF4609@sirena.org.uk> (raw)
In-Reply-To: <1412372246-10489-2-git-send-email-benzh@chromium.org>
[-- Attachment #1: Type: text/plain, Size: 234 bytes --]
On Fri, Oct 03, 2014 at 02:37:25PM -0700, Ben Zhang wrote:
> +#ifdef CONFIG_ACPI
> + .acpi_match_table = ACPI_PTR(rt5677_acpi_id),
> +#endif
Why do you need this ifdef - surely the whole point of ACPI_PTR() is to
avoid needing it?
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
next prev parent reply other threads:[~2014-10-07 19:12 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-03 21:37 [PATCH 1/3] ASoC: rt5677: Include gpio driver header Ben Zhang
2014-10-03 21:37 ` [PATCH 2/3] ASoC: rt5677: Add ACPI device probing Ben Zhang
2014-10-07 19:12 ` Mark Brown [this message]
2014-10-03 21:37 ` [PATCH 3/3] ASoC: rt5677: Add jack detection support Ben Zhang
2014-10-07 19:35 ` Mark Brown
2014-10-07 19:36 ` [PATCH 1/3] ASoC: rt5677: Include gpio driver header Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141007191212.GF4609@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=bardliao@realtek.com \
--cc=benzh@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=oder_chiou@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®