From: Steven Rostedt <rostedt@goodmis.org>
To: linux-kernel@vger.kernel.org
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
Andrew Morton <akpm@linux-foundation.org>,
Satoru Takeuchi <satoru.takeuchi@gmail.com>,
Chris J Arges <chris.j.arges@canonical.com>
Subject: [PATCH 2/4] ktest: add ability to skip during BISECT_MANUAL
Date: Tue, 07 Oct 2014 17:16:33 -0400 [thread overview]
Message-ID: <20141007211700.052451355@goodmis.org> (raw)
In-Reply-To: <20141007211631.365194240@goodmis.org>
[-- Attachment #1: 0002-ktest-add-ability-to-skip-during-BISECT_MANUAL.patch --]
[-- Type: text/plain, Size: 1221 bytes --]
From: Chris J Arges <chris.j.arges@canonical.com>
When doing a manual bisect, a build can fail or a test can be inconclusive.
In these cases it would be helpful to be able to skip the test entirely.
Link: http://lkml.kernel.org/r/1409164021-2136-1-git-send-email-chris.j.arges@canonical.com
Reviewed-by: Satoru Takeuchi <satoru.takeuchi@gmail.com>
Signed-off-by: Chris J Arges <chris.j.arges@canonical.com>
Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
---
tools/testing/ktest/ktest.pl | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/tools/testing/ktest/ktest.pl b/tools/testing/ktest/ktest.pl
index 3b7a180d9c0d..085452fa045b 100755
--- a/tools/testing/ktest/ktest.pl
+++ b/tools/testing/ktest/ktest.pl
@@ -2338,15 +2338,17 @@ sub success {
sub answer_bisect {
for (;;) {
- doprint "Pass or fail? [p/f]";
+ doprint "Pass, fail, or skip? [p/f/s]";
my $ans = <STDIN>;
chomp $ans;
if ($ans eq "p" || $ans eq "P") {
return 1;
} elsif ($ans eq "f" || $ans eq "F") {
return 0;
+ } elsif ($ans eq "s" || $ans eq "S") {
+ return -1;
} else {
- print "Please answer 'P' or 'F'\n";
+ print "Please answer 'p', 'f', or 's'\n";
}
}
}
--
2.0.1
next prev parent reply other threads:[~2014-10-07 21:17 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-07 21:16 [PATCH 0/4] [GIT PULL] ktest: Updates for 3.18 Steven Rostedt
2014-10-07 21:16 ` [PATCH 1/4] ktest: Add PATCHCHECK_CHERRY Steven Rostedt
2014-10-07 21:16 ` Steven Rostedt [this message]
2014-10-07 21:16 ` [PATCH 3/4] ktest: Fix check for new kernel success on rebooting to good kernel Steven Rostedt
2014-10-07 21:16 ` [PATCH 4/4] ktest: Dont bother with bisect good or bad on replay Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141007211700.052451355@goodmis.org \
--to=rostedt@goodmis.org \
--cc=akpm@linux-foundation.org \
--cc=chris.j.arges@canonical.com \
--cc=linux-kernel@vger.kernel.org \
--cc=satoru.takeuchi@gmail.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome