From: Felipe Balbi <balbi@ti.com>
To: Robert Baldyga <r.baldyga@samsung.com>
Cc: <balbi@ti.com>, <gregkh@linuxfoundation.org>,
<linux-usb@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<mina86@mina86.com>, <andrzej.p@samsung.com>,
<m.szyprowski@samsung.com>
Subject: Re: [PATCH] usb: gadget: f_fs: remove redundant ffs_data_get()
Date: Thu, 9 Oct 2014 09:21:17 -0500 [thread overview]
Message-ID: <20141009142117.GB16002@saruman> (raw)
In-Reply-To: <1412840476-2767-1-git-send-email-r.baldyga@samsung.com>
[-- Attachment #1: Type: text/plain, Size: 737 bytes --]
On Thu, Oct 09, 2014 at 09:41:16AM +0200, Robert Baldyga wrote:
> During FunctionFS bind, ffs_data_get() function was called twice
> (in functionfs_bind() and in ffs_do_functionfs_bind()), while on unbind
> ffs_data_put() was called once (in functionfs_unbind() function).
> In result refcount never reached value 0, and ffs memory resources has
> been never released.
>
> Since ffs_data_get() call in ffs_do_functionfs_bind() is redundant
> and not neccessary, we remove it to have equal number of gets ans puts,
> and free allocated memory after refcount reach 0.
>
> Signed-off-by: Robert Baldyga <r.baldyga@samsung.com>
Which commit is this fixing ? does it deserve a stable backport ? How
far back ?
--
balbi
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2014-10-09 14:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-09 7:41 Robert Baldyga
2014-10-09 10:39 ` Michal Nazarewicz
2014-10-09 14:21 ` Felipe Balbi [this message]
2014-10-10 5:17 ` Robert Baldyga
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141009142117.GB16002@saruman \
--to=balbi@ti.com \
--cc=andrzej.p@samsung.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=mina86@mina86.com \
--cc=r.baldyga@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome