From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932637AbaJIVwf (ORCPT ); Thu, 9 Oct 2014 17:52:35 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:37197 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752466AbaJIVw3 (ORCPT ); Thu, 9 Oct 2014 17:52:29 -0400 Date: Thu, 9 Oct 2014 14:52:28 -0700 From: Greg KH To: Matthias Brugger Cc: linux-kernel@vger.kernel.org, jslaby@suse.cz, heiko@sntech.de, yingjoe.chen@gmail.com, ibanezchen@gmail.com, linux-serial@vger.kernel.org Subject: Re: [PATCH] tty: serial: 8250_mtk: Fix quot calculation Message-ID: <20141009215228.GA23507@kroah.com> References: <1412871811-5986-1-git-send-email-matthias.bgg@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1412871811-5986-1-git-send-email-matthias.bgg@gmail.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Oct 09, 2014 at 06:23:31PM +0200, Matthias Brugger wrote: > The calculation of value quot for highspeed register set to three > was wrong. This patch fixes the calculation so that the serial port > for baudrates bigger then 576000 baud is working correctly. > > Signed-off-by: Matthias Brugger > --- > drivers/tty/serial/8250/8250_mtk.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/tty/serial/8250/8250_mtk.c b/drivers/tty/serial/8250/8250_mtk.c > index 1c4b4bf..4376c48 100644 > --- a/drivers/tty/serial/8250/8250_mtk.c > +++ b/drivers/tty/serial/8250/8250_mtk.c > @@ -81,7 +81,7 @@ mtk8250_set_termios(struct uart_port *port, struct ktermios *termios, > /* Set to highest baudrate supported */ > if (baud >= 1152000) > baud = 921600; > - quot = DIV_ROUND_CLOSEST(port->uartclk, 256 * baud); > + quot = (port->uartclk / (256 * baud)) + 1; > } > > /* Has this always been incorrect, or was it caused by a specific patch? Should it go to the stable kernels? If so, how far back? thanks, greg k-h