From: Greg KH <gregkh@linuxfoundation.org>
To: Erich Cordoba Malibran <erich.cordoba@yandex.com>
Cc: linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org
Subject: Re: [PATCH] staging: wlan-ng: Renamed prism2_fragmenthreshold in prism2mib.c
Date: Mon, 13 Oct 2014 05:27:08 +0200 [thread overview]
Message-ID: <20141013032708.GB26646@kroah.com> (raw)
In-Reply-To: <1413167372-5568-1-git-send-email-erich.cordoba@yandex.com>
On Sun, Oct 12, 2014 at 09:29:32PM -0500, Erich Cordoba Malibran wrote:
> From: Erich Cordoba Malibran <erich.cordoba@yandex.com>
>
> Renamed function to fix style issues.
Why is changing a name, to a misspelled one, a "style issue fix"?
>
> Signed-off-by: Erich Cordoba Malibran <erich.cordoba@yandex.com>
> ---
> drivers/staging/wlan-ng/prism2mib.c | 26 +++++++++++++-------------
> 1 file changed, 13 insertions(+), 13 deletions(-)
>
> diff --git a/drivers/staging/wlan-ng/prism2mib.c b/drivers/staging/wlan-ng/prism2mib.c
> index 0163e06..30d224f 100644
> --- a/drivers/staging/wlan-ng/prism2mib.c
> +++ b/drivers/staging/wlan-ng/prism2mib.c
> @@ -132,12 +132,12 @@ static int prism2mib_excludeunencrypted(struct mibrec *mib,
> struct p80211msg_dot11req_mibset *msg,
> void *data);
>
> -static int prism2mib_fragmentationthreshold(struct mibrec *mib,
> - int isget,
> - wlandevice_t *wlandev,
> - hfa384x_t *hw,
> - struct p80211msg_dot11req_mibset *msg,
> - void *data);
> +static int prism2mib_fragmenthreshold(struct mibrec *mib,
> + int isget,
> + wlandevice_t *wlandev,
> + hfa384x_t *hw,
> + struct p80211msg_dot11req_mibset *msg,
> + void *data);
>
> static int prism2mib_priv(struct mibrec *mib,
> int isget,
> @@ -198,7 +198,7 @@ static struct mibrec mibtab[] = {
> {DIDmib_dot11mac_dot11OperationTable_dot11FragmentationThreshold,
> F_STA | F_READ | F_WRITE,
> HFA384x_RID_FRAGTHRESH, 0, 0,
> - prism2mib_fragmentationthreshold},
> + prism2mib_fragmenthreshold},
> {DIDmib_dot11mac_dot11OperationTable_dot11MaxTransmitMSDULifetime,
> F_STA | F_READ,
> HFA384x_RID_MAXTXLIFETIME, 0, 0,
> @@ -660,12 +660,12 @@ static int prism2mib_excludeunencrypted(struct mibrec *mib,
> *
> ----------------------------------------------------------------*/
>
> -static int prism2mib_fragmentationthreshold(struct mibrec *mib,
> - int isget,
> - wlandevice_t *wlandev,
> - hfa384x_t *hw,
> - struct p80211msg_dot11req_mibset *msg,
> - void *data)
> +static int prism2mib_fragmenthreshold(struct mibrec *mib,
> + int isget,
> + wlandevice_t *wlandev,
> + hfa384x_t *hw,
> + struct p80211msg_dot11req_mibset *msg,
> + void *data)
> {
> int result;
> u32 *uint32 = (u32 *) data;
> --
> 2.1.2
I don't understand the problem you are trying to solve here, what is it?
confused,
greg k-h
next prev parent reply other threads:[~2014-10-13 3:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-13 2:29 Erich Cordoba Malibran
2014-10-13 3:27 ` Greg KH [this message]
2014-10-13 19:32 ` Erich Cordoba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141013032708.GB26646@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=devel@driverdev.osuosl.org \
--cc=erich.cordoba@yandex.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®