mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Henning Schild <henning@hennsch.de>
To: "Deucher, Alexander" <Alexander.Deucher@amd.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"Rafał Miłecki" <zajec5@gmail.com>
Subject: Re: [PATCH] drm/radeon: remove code that can never get executed
Date: Mon, 13 Oct 2014 19:54:51 +0200	[thread overview]
Message-ID: <20141013195451.52b0fcd8@hennsch.de> (raw)
In-Reply-To: <A3397C8B8B789E45844E7EC5DEAD89D05993B523@satlexdag05.amd.com>

On Mon, 13 Oct 2014 17:31:12 +0000
"Deucher, Alexander" <Alexander.Deucher@amd.com> wrote:

> Ah, ok.  The attached patches should do the trick then.

Yes that would do the trick. But i suggest doing the NULL initialization
in drm_edid_to_speaker_allocation.
The kernel doc suggests that whatever drm_edid_to_speaker_allocation
returns should be freed. Depending on which version you prefer, the
doc might have to be changed as well.

Henning

      reply	other threads:[~2014-10-13 17:54 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-11 12:37 [PATCH] drm/radeon: fix dangling pointer kfree Henning Schild
2014-10-11 12:51 ` [PATCH] drm/radeon: remove code that can never get executed Henning Schild
2014-10-13 16:08   ` Deucher, Alexander
2014-10-13 16:44     ` Henning Schild
2014-10-13 17:31       ` Deucher, Alexander
2014-10-13 17:54         ` Henning Schild [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141013195451.52b0fcd8@hennsch.de \
    --to=henning@hennsch.de \
    --cc=Alexander.Deucher@amd.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=zajec5@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome