From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755947AbaJOCFI (ORCPT ); Tue, 14 Oct 2014 22:05:08 -0400 Received: from shards.monkeyblade.net ([149.20.54.216]:46481 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755536AbaJOCFH (ORCPT ); Tue, 14 Oct 2014 22:05:07 -0400 Date: Tue, 14 Oct 2014 22:05:05 -0400 (EDT) Message-Id: <20141014.220505.586366171329066629.davem@davemloft.net> To: haiyangz@microsoft.com Cc: netdev@vger.kernel.org, kys@microsoft.com, olaf@aepfle.de, jasowang@redhat.com, linux-kernel@vger.kernel.org, driverdev-devel@linuxdriverproject.org Subject: Re: [PATCH net-next,v2] hyperv: Add handling of IP header with option field in netvsc_set_hash() From: David Miller In-Reply-To: <1413317117-28678-1-git-send-email-haiyangz@microsoft.com> References: <1413317117-28678-1-git-send-email-haiyangz@microsoft.com> X-Mailer: Mew version 6.6 on Emacs 24.3 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.7 (shards.monkeyblade.net [149.20.54.216]); Tue, 14 Oct 2014 19:05:06 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Haiyang Zhang Date: Tue, 14 Oct 2014 20:05:17 +0000 > In case that the IP header has optional field at the end, this patch will > get the port numbers after that field, and compute the hash. > > Signed-off-by: Haiyang Zhang > Reviewed-by: K. Y. Srinivasan This isn't even close to what I asked for. I said to remove all of this by-hand header parsing code in the hyperv driver, and use the generic code networking facilities that exist already to do this.