From: One Thousand Gnomes <gnomes@lxorguk.ukuu.org.uk>
To: linux-pcmcia@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: [PATCH] pcmcia: fix sign extension on 64bit machines
Date: Tue, 14 Oct 2014 13:39:41 +0100 [thread overview]
Message-ID: <20141014133941.2600222e@alan.etchedpixels.co.uk> (raw)
If you try and run pcmcia on a 64bit box the upper 32bits of the resource
flags all end up set due to a sign extension bug in the PCMCIA core
Signed-off-by: Alan Cox <alan@linux.intel.com>
diff -u --new-file --recursive --exclude-from ac/.gitignore next/drivers/pcmcia/cs_internal.h ac/drivers/pcmcia/cs_internal.h
--- next/drivers/pcmcia/cs_internal.h 2013-10-28 11:40:29.717315588 +0000
+++ ac/drivers/pcmcia/cs_internal.h 2014-09-06 17:25:32.959662243 +0100
@@ -82,7 +82,7 @@
extern int static_init(struct pcmcia_socket *s);
extern struct resource *pcmcia_make_resource(unsigned long start,
unsigned long end,
- int flags, const char *name);
+ unsigned long flags, const char *name);
/*
* Stuff internal to module "pcmcia_core":
diff -u --new-file --recursive --exclude-from ac/.gitignore next/drivers/pcmcia/rsrc_mgr.c ac/drivers/pcmcia/rsrc_mgr.c
--- next/drivers/pcmcia/rsrc_mgr.c 2013-10-28 11:40:29.721315588 +0000
+++ ac/drivers/pcmcia/rsrc_mgr.c 2014-09-06 17:24:51.671663325 +0100
@@ -31,7 +31,7 @@
}
struct resource *pcmcia_make_resource(unsigned long start, unsigned long end,
- int flags, const char *name)
+ unsigned long flags, const char *name)
{
struct resource *res = kzalloc(sizeof(*res), GFP_KERNEL);
reply other threads:[~2014-10-14 12:40 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141014133941.2600222e@alan.etchedpixels.co.uk \
--to=gnomes@lxorguk.ukuu.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pcmcia@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®