mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jiri Olsa <jolsa@redhat.com>
To: "Liang, Kan" <kan.liang@intel.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"ak@linux.intel.com" <ak@linux.intel.com>,
	"acme@kernel.org" <acme@kernel.org>,
	Steven Rostedt <rostedt@goodmis.org>,
	Namhyung Kim <namhyung@kernel.org>
Subject: [PATCH] perf tools: Do not call pevent_free_format when deleting tracepoint
Date: Tue, 14 Oct 2014 16:02:04 +0200	[thread overview]
Message-ID: <20141014140204.GA1639@krava.redhat.com> (raw)
In-Reply-To: <37D7C6CF3E00A74B8858931C1DB2F077016237E7@SHSMSX103.ccr.corp.intel.com>

On Mon, Oct 13, 2014 at 03:43:18PM +0000, Liang, Kan wrote:
> Hi Jolsa,
> 
> Does the new patch set work on your machine?
> I tested the V8 patch set on haswell, ivybridge and Romley platform,
> I cannot reproduce the issue you mentioned.
> Could you please try the latest V8 patch? 

actually it still does, but it looks like another issue,
I think we need patch below.. I'll now check rest of your
patches.

Steven,
does the patch below make sense to you? I dont think we want
to allow freeing of the event_format that pevent keeps in
the array.

jirka


---
The libtraceevent library's main handle 'struct pevent' holds
pointers of every event that was added to it via functions:
  pevent_parse_format
  pevent_parse_event

All added events are released within the handle cleanup
in pevent_free.

Signed-off-by: Jiri Olsa <jolsa@kernel.org>
Cc: Steven Rostedt <rostedt@goodmis.org>
Cc: Corey Ashford <cjashfor@linux.vnet.ibm.com>
Cc: David Ahern <dsahern@gmail.com>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Ingo Molnar <mingo@kernel.org>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Arnaldo Carvalho de Melo <acme@redhat.com>
---
 tools/perf/util/evsel.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/tools/perf/util/evsel.c b/tools/perf/util/evsel.c
index e0868a901c4a..f5cc101428be 100644
--- a/tools/perf/util/evsel.c
+++ b/tools/perf/util/evsel.c
@@ -824,8 +824,6 @@ void perf_evsel__delete(struct perf_evsel *evsel)
 	perf_evsel__exit(evsel);
 	close_cgroup(evsel->cgrp);
 	zfree(&evsel->group_name);
-	if (evsel->tp_format)
-		pevent_free_format(evsel->tp_format);
 	zfree(&evsel->name);
 	free(evsel);
 }
-- 
1.9.3



  parent reply	other threads:[~2014-10-14 14:02 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-07 15:08 [PATCH V8 0/4] perf tools: pmu event new style format fix kan.liang
2014-10-07 15:08 ` [PATCH V8 1/4] Revert "perf tools: Default to cpu// for events v5" kan.liang
2014-10-16  5:22   ` [tip:perf/urgent] " tip-bot for Kan Liang
2014-10-07 15:08 ` [PATCH V8 2/4] perf tools: parse the pmu event prefix and suffix kan.liang
2014-10-16  5:22   ` [tip:perf/urgent] perf tools: Parse " tip-bot for Kan Liang
2014-10-07 15:08 ` [PATCH V8 3/4] perf tools: Add support to new style format of kernel PMU event kan.liang
2014-10-16  5:22   ` [tip:perf/urgent] " tip-bot for Kan Liang
2014-10-07 15:08 ` [PATCH V8 4/4] perf tools: Add test case for pmu event new style format kan.liang
2014-10-16  5:23   ` [tip:perf/urgent] perf test: " tip-bot for Kan Liang
2014-10-13 15:43 ` [PATCH V8 0/4] perf tools: pmu event new style format fix Liang, Kan
2014-10-13 17:05   ` Jiri Olsa
2014-10-14 14:02   ` Jiri Olsa [this message]
2014-10-15 15:00 ` Jiri Olsa
2014-10-15 19:13   ` Arnaldo Carvalho de Melo
2014-11-04 10:55 [PATCH] perf tools: Do not call pevent_free_format when deleting tracepoint Jiri Olsa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141014140204.GA1639@krava.redhat.com \
    --to=jolsa@redhat.com \
    --cc=acme@kernel.org \
    --cc=ak@linux.intel.com \
    --cc=kan.liang@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=namhyung@kernel.org \
    --cc=rostedt@goodmis.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome