From: Stephen Rothwell <sfr@canb.auug.org.au>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Peter Oberparleiter <oberpar@linux.vnet.ibm.com>,
Riku Voipio <riku.voipio@linaro.org>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] gcov: add ARM64 to GCOV_PROFILE_ALL
Date: Wed, 15 Oct 2014 08:54:34 +1100 [thread overview]
Message-ID: <20141015085434.2c155706@canb.auug.org.au> (raw)
In-Reply-To: <20141014144048.e2bf1f5ec23c39d2a59700f6@linux-foundation.org>
[-- Attachment #1: Type: text/plain, Size: 977 bytes --]
Hi Andrew,
On Tue, 14 Oct 2014 14:40:48 -0700 Andrew Morton <akpm@linux-foundation.org> wrote:
>
> > > diff --git a/kernel/gcov/Kconfig b/kernel/gcov/Kconfig
> > > index cf66c5c..3b74087 100644
> > > --- a/kernel/gcov/Kconfig
> > > +++ b/kernel/gcov/Kconfig
> > > @@ -35,7 +35,7 @@ config GCOV_KERNEL
> > > config GCOV_PROFILE_ALL
> > > bool "Profile entire Kernel"
> > > depends on GCOV_KERNEL
> > > - depends on SUPERH || S390 || X86 || PPC || MICROBLAZE || ARM
> > > + depends on SUPERH || S390 || X86 || PPC || MICROBLAZE || ARM || ARM64
> > > default n
> > > ---help---
> > > This options activates profiling for the entire kernel.
>
> gcov is doing this the wrong way. There should be a `select
> GCOV_PROFILE_ALL' in each arch/*/Kconfig.
What they should actually do is select (say) ARCH_HAS_GCOV_PROFILE_ALL
and then GCOV_PROFILE_ALL should depend on that.
--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2014-10-14 21:54 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-09 10:54 Riku Voipio
2014-10-09 14:00 ` Peter Oberparleiter
2014-10-14 21:40 ` Andrew Morton
2014-10-14 21:54 ` Stephen Rothwell [this message]
2014-10-16 13:46 Riku Voipio
2014-10-16 14:01 ` Riku Voipio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141015085434.2c155706@canb.auug.org.au \
--to=sfr@canb.auug.org.au \
--cc=akpm@linux-foundation.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=oberpar@linux.vnet.ibm.com \
--cc=riku.voipio@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome