From: David Miller <davem@davemloft.net>
To: eric.dumazet@gmail.com
Cc: tgraf@suug.ch, sgunderson@bigfoot.com,
linux-kernel@vger.kernel.org, nikolay@redhat.com
Subject: Re: getaddrinfo slowdown in 3.17.1, due to getifaddrs
Date: Fri, 17 Oct 2014 12:30:55 -0400 (EDT) [thread overview]
Message-ID: <20141017.123055.1381956207136104867.davem@davemloft.net> (raw)
In-Reply-To: <1413563283.24953.30.camel@edumazet-glaptop2.roam.corp.google.com>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Fri, 17 Oct 2014 09:28:03 -0700
> On Fri, 2014-10-17 at 07:25 +0100, Thomas Graf wrote:
>> On 10/17/14 at 02:34am, Steinar H. Gunderson wrote:
>> > On Fri, Oct 17, 2014 at 02:21:32AM +0200, Steinar H. Gunderson wrote:
>> > > Hi,
>> > >
>> > > We recently upgraded a machine from 3.14.5 to 3.17.1, and a Perl script we're
>> > > running to poll SNMP suddenly needed ten times as much time to complete.
>> >
>> > e341694e3eb57fcda9f1adc7bfea42fe080d8d7a looks like it might cause something
>> > like this (it certainly added the synchronize_net() call). Cc-ing people on
>> > that commit; quoting the entire rest of the message for reference.
>>
>> I think the only option at this point is to re-add the nltable lock to
>> netlink_lookup() so we can drop the synchronize_net() until we find a
>> way to RCUify socket destruction. I will cook up a patch today unless
>> somebody can come up with a smarter way to work around needing the
>> synchronize_net().
>
> I had a patch to add conditional RCUify socket destruction for some kind
> of sockets (opt-in at protocol level).
>
> I needed this to remove too expensive UDP socket refcount inc/dec (so
> get rid of SLAB_DESTROY_BY_RCU, and instead use call_rcu() or kfree_rcu
> thing)
>
> But I couldn't finish and submit this for 3.18, and I believe I got it
> wrong anyway. Cant remember exact details right now, maybe later in the
> day, once my headache is better.
Can I ask a serious question? What is the synchronize_net() in AF_NETLINK
exactly needed for?
next prev parent reply other threads:[~2014-10-17 16:30 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-17 0:21 Steinar H. Gunderson
2014-10-17 0:34 ` Steinar H. Gunderson
2014-10-17 6:25 ` Thomas Graf
2014-10-17 16:28 ` Eric Dumazet
2014-10-17 16:30 ` David Miller [this message]
2014-10-17 21:19 ` Eric Dumazet
2014-10-21 13:25 ` Steinar H. Gunderson
2014-10-21 13:31 ` Thomas Graf
2014-10-23 23:37 ` Steinar H. Gunderson
2014-11-02 21:55 ` Steinar H. Gunderson
2014-11-02 23:25 ` David Miller
2014-10-18 10:45 ` Steinar H. Gunderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141017.123055.1381956207136104867.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=nikolay@redhat.com \
--cc=sgunderson@bigfoot.com \
--cc=tgraf@suug.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®