From: Mark Brown <broonie@kernel.org>
To: Gyungoh Yoo <gyungoh@gmail.com>
Cc: sameo@linux.intel.com, lee.jones@linaro.org, jg1.han@samsung.com,
cooloney@gmail.com, lgirdwood@gmail.com,
jack.yoo@skyworksinc.com, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org, grant.likely@linaro.org,
robh+dt@kernel.org, mark.rutland@arm.com,
ijc+devicetree@hellion.org.uk, galak@codeaurora.org,
pawel.moll@arm.com, heiko@sntech.de, jason@lakedaemon.net,
shawn.guo@freescale.com, treding@nvidia.com,
florian.vaussard@epfl.ch, trivial@kernel.org, linux@roeck-us.net,
andrew@lunn.ch, jic23@kernel.org
Subject: Re: [RESUBMIT PATCH v4 7/8] regulator: sky81452: Add compatible string for device binding
Date: Fri, 17 Oct 2014 16:26:05 +0200 [thread overview]
Message-ID: <20141017142605.GU1820@sirena.org.uk> (raw)
In-Reply-To: <20141017104309.GA3136@jack-ThinkPad-T520>
[-- Attachment #1: Type: text/plain, Size: 963 bytes --]
On Fri, Oct 17, 2014 at 07:43:09PM +0900, Gyungoh Yoo wrote:
> Are you talking about simplification using of_regulator_match()?
> This driver has only one regulator.
> Is the API also useful for this driver?
The thing I'm seeing is that the binding for your device with the
subnode looks very much like the device trees of devices with multiple
regulators. The fact that you only have one regulator is a bit
difference but not that much. It seems like drivers should fit into one
of two patterns: either the regulator is described in the root node for
the device for single purpose devices or there should be a collection of
regulators like is supported with this helper API. Having a collection
with only one node doesn't seem to be a problem in any way.
> Like reg-fixed-voltage, how about using of_get_fixed_voltage_config()?
The driver doesn't seem to need any property parsing of its own so it
shoudn't need anything beyond basic calls into the core.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
next prev parent reply other threads:[~2014-10-17 14:26 UTC|newest]
Thread overview: 106+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-08 9:08 [PATCH 1/3] Adding Skyworks SKY81452 MFD driver Gyungoh Yoo
2014-08-12 2:21 ` Gyungoh Yoo
[not found] ` <CADDor3-uhXm2x1Hpy4NT9J2OZ+83D-854GkG8JWz8MYUh0YtwA@mail.gmail.com>
2014-08-12 7:16 ` Lee Jones
2014-08-21 9:45 ` Lee Jones
2014-08-21 9:59 ` Thierry Reding
2014-08-21 11:19 ` Lee Jones
2014-08-25 7:06 ` Gyungoh Yoo
2014-08-26 8:22 ` Lee Jones
2014-08-27 4:06 ` Gyungoh Yoo
2014-08-27 8:39 ` Lee Jones
2014-08-28 1:29 ` Gyungoh Yoo
2014-08-28 10:38 ` [PATCH v2 0/7] Adding Skyworks SKY81452 device drivers Gyungoh Yoo
2014-08-28 10:43 ` [PATCH v2 1/7] Adding Skyworks SKY81452 MFD driver Gyungoh Yoo
2014-08-29 2:03 ` [PATCH v2.1 " Gyungoh Yoo
2014-09-04 9:28 ` Lee Jones
2014-09-05 4:24 ` [PATCH v2.2 1/7] regulator: sky81452: " Gyungoh Yoo
2014-08-28 10:46 ` [PATCH v2 2/7] Adding Skyworks SKY81452 regulator driver Gyungoh Yoo
2014-08-28 11:02 ` Mark Brown
2014-08-29 2:21 ` Gyungoh Yoo
2014-08-28 10:49 ` [PATCH v2 3/7] Adding Skyworks SKY81452 backlight driver Gyungoh Yoo
2014-08-28 10:56 ` [PATCH v2 4/7] Adding SKY81452 MFD device tree bindings document Gyungoh Yoo
2014-08-28 10:58 ` [PATCH v2 5/7] Adding SKY81452 regulator " Gyungoh Yoo
2014-09-01 2:46 ` Gyungoh Yoo
2014-08-28 11:00 ` [PATCH v2 6/7] Adding SKY81452 backlight " Gyungoh Yoo
2014-08-28 11:01 ` [PATCH v2 7/7] Adding SKY81452 backlight document Gyungoh Yoo
2014-10-07 4:55 ` [RESUBMIT PATCH v3 0/8] Adding Skyworks SKY81452 device drivers Gyungoh Yoo
2014-10-07 4:58 ` [RESUBMIT PATCH v3 1/8] mfd: Add support for Skyworks SKY81452 driver Gyungoh Yoo
2014-10-07 8:12 ` Lee Jones
2014-10-07 8:23 ` Gyungoh Yoo
2014-10-07 5:01 ` [RESUBMIT PATCH v3 2/8] backlight: Add support Skyworks SKY81452 backlight driver Gyungoh Yoo
2014-10-08 1:03 ` Jingoo Han
2014-10-08 8:55 ` Gyungoh Yoo
2014-10-07 5:04 ` [RESUBMIT PATCH v3 3/8] devicetree: mfd: Add new SKY81452 mfd binding Gyungoh Yoo
2014-10-07 5:04 ` [RESUBMIT PATCH v3 4/8] devicetree: backlight: add new SKY81452 backlight binding Gyungoh Yoo
2014-10-07 5:06 ` [RESUBMIT PATCH v3 5/8] devicetree: Add vendor prefix for Skyworks Solutions, Inc Gyungoh Yoo
2014-10-07 5:09 ` [RESUBMIT PATCH v3 6/8] devicetree: i2c: Add SKY81452 to the Trivial Devices list Gyungoh Yoo
2014-10-07 5:11 ` [RESUBMIT PATCH v3 7/8] regulator: sky81452: Add compatible string for device binding Gyungoh Yoo
2014-10-07 12:52 ` Mark Brown
2014-10-08 8:51 ` Gyungoh Yoo
2014-10-07 5:13 ` [RESUBMIT PATCH v3 8/8] devicetree: " Gyungoh Yoo
2014-10-13 5:47 ` [RESUBMIT PATCH v4 0/8] Add Skyworks SKY81452 device drivers Gyungoh Yoo
2014-10-13 5:47 ` [RESUBMIT PATCH v4 1/8] mfd: Add support for Skyworks SKY81452 driver Gyungoh Yoo
2014-10-21 12:30 ` Lee Jones
2014-10-23 3:16 ` Gyungoh Yoo
2014-10-13 5:47 ` [RESUBMIT PATCH v4 2/8] backlight: Add support Skyworks SKY81452 backlight driver Gyungoh Yoo
2014-10-13 5:47 ` [RESUBMIT PATCH v4 3/8] devicetree: mfd: Add new SKY81452 mfd binding Gyungoh Yoo
2014-10-13 5:47 ` [RESUBMIT PATCH v4 4/8] devicetree: backlight: Add new SKY81452 backlight binding Gyungoh Yoo
2014-10-13 5:47 ` [RESUBMIT PATCH v4 5/8] devicetree: Add vendor prefix for Skyworks Solutions, Inc Gyungoh Yoo
2014-10-13 5:47 ` [RESUBMIT PATCH v4 6/8] devicetree: i2c: Add SKY81452 to the Trivial Devices list Gyungoh Yoo
2014-10-13 5:47 ` [RESUBMIT PATCH v4 7/8] regulator: sky81452: Add compatible string for device binding Gyungoh Yoo
2014-10-13 10:35 ` Mark Brown
2014-10-14 1:11 ` Gyungoh Yoo
2014-10-14 7:56 ` Mark Brown
2014-10-17 9:19 ` Gyungoh Yoo
2014-10-17 10:17 ` Mark Brown
2014-10-17 10:43 ` Gyungoh Yoo
2014-10-17 14:26 ` Mark Brown [this message]
2014-10-20 6:10 ` Gyungoh Yoo
2014-10-22 10:27 ` Mark Brown
2014-10-23 3:14 ` Gyungoh Yoo
2014-10-23 13:01 ` Mark Brown
2014-10-24 7:54 ` Gyungoh Yoo
2014-10-13 5:47 ` [RESUBMIT PATCH v4 8/8] devicetree: " Gyungoh Yoo
2014-10-27 7:02 ` [RESUBMIT PATCH v5 0/8] Add Skyworks SKY81452 device drivers gyungoh
2014-10-27 7:02 ` [RESUBMIT PATCH v5 1/8] mfd: Add support for Skyworks SKY81452 driver gyungoh
2014-10-27 7:02 ` [RESUBMIT PATCH v5 2/8] backlight: Add support Skyworks SKY81452 backlight driver gyungoh
2014-10-27 7:05 ` Varka Bhadram
2014-10-27 7:19 ` Gyungoh Yoo
2014-10-27 7:02 ` [RESUBMIT PATCH v5 3/8] devicetree: mfd: Add new SKY81452 mfd binding gyungoh
2014-10-27 7:02 ` [RESUBMIT PATCH v5 4/8] devicetree: backlight: Add new SKY81452 backlight binding gyungoh
2014-10-27 7:02 ` [RESUBMIT PATCH v5 5/8] devicetree: Add vendor prefix for Skyworks Solutions, Inc gyungoh
2014-10-27 7:02 ` [RESUBMIT PATCH v5 6/8] devicetree: i2c: Add SKY81452 to the Trivial Devices list gyungoh
2014-10-27 7:02 ` [RESUBMIT PATCH v5 7/8] regulator: sky81452: Add compatible string for device binding gyungoh
2014-10-27 7:02 ` [RESUBMIT PATCH v5 8/8] devicetree: " gyungoh
2014-10-31 7:08 ` [RESUBMIT PATCH v6 0/8] Add Skyworks SKY81452 device drivers gyungoh
2014-10-31 7:08 ` [RESUBMIT PATCH v6 1/8] mfd: Add support for Skyworks SKY81452 driver gyungoh
2014-11-03 17:14 ` Lee Jones
2014-11-03 21:28 ` Paul Bolle
2014-11-03 22:30 ` Lee Jones
2014-11-04 9:05 ` Paul Bolle
2014-11-04 9:16 ` Lee Jones
2014-11-04 11:38 ` Mark Brown
2014-11-04 14:35 ` Lee Jones
2014-11-04 10:54 ` Lee Jones
2014-11-04 9:17 ` Lee Jones
2014-10-31 7:08 ` [RESUBMIT PATCH v6 2/8] backlight: Add support Skyworks SKY81452 backlight driver gyungoh
2014-10-31 7:08 ` [RESUBMIT PATCH v6 3/8] devicetree: mfd: Add new SKY81452 mfd binding gyungoh
2014-10-31 16:36 ` Mark Brown
2014-11-03 17:06 ` Lee Jones
2014-10-31 7:08 ` [RESUBMIT PATCH v6 4/8] devicetree: backlight: Add new SKY81452 backlight binding gyungoh
2014-10-31 7:08 ` [RESUBMIT PATCH v6 5/8] devicetree: Add vendor prefix for Skyworks Solutions, Inc gyungoh
2014-11-03 17:07 ` Lee Jones
2014-10-31 7:08 ` [RESUBMIT PATCH v6 6/8] devicetree: i2c: Add SKY81452 to the Trivial Devices list gyungoh
2014-10-31 7:08 ` [RESUBMIT PATCH v6 7/8] regulator: sky81452: Add compatible string for device binding gyungoh
2014-10-31 16:44 ` Mark Brown
2014-11-03 21:45 ` Paul Bolle
2014-11-04 0:55 ` Mark Brown
2014-11-06 4:45 ` Gyungoh Yoo
2014-11-04 0:43 ` Gyungoh Yoo
2014-11-04 0:53 ` Mark Brown
2014-11-04 5:45 ` Gyungoh Yoo
2014-11-04 11:41 ` Mark Brown
2014-11-06 4:38 ` Gyungoh Yoo
2014-10-31 7:08 ` [RESUBMIT PATCH v6 8/8] devicetree: " gyungoh
2014-11-11 11:10 ` [RESUBMIT PATCH v6 0/8] Add Skyworks SKY81452 device drivers Lee Jones
2014-11-13 13:20 ` Gyungoh Yoo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141017142605.GU1820@sirena.org.uk \
--to=broonie@kernel.org \
--cc=andrew@lunn.ch \
--cc=cooloney@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=florian.vaussard@epfl.ch \
--cc=galak@codeaurora.org \
--cc=grant.likely@linaro.org \
--cc=gyungoh@gmail.com \
--cc=heiko@sntech.de \
--cc=ijc+devicetree@hellion.org.uk \
--cc=jack.yoo@skyworksinc.com \
--cc=jason@lakedaemon.net \
--cc=jg1.han@samsung.com \
--cc=jic23@kernel.org \
--cc=lee.jones@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
--cc=sameo@linux.intel.com \
--cc=shawn.guo@freescale.com \
--cc=treding@nvidia.com \
--cc=trivial@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®