From: Jiri Olsa <jolsa@redhat.com>
To: Andi Kleen <andi@firstfloor.org>
Cc: linux-kernel@vger.kernel.org, namhyung@kernel.org,
acme@kernel.org, Andi Kleen <ak@linux.intel.com>
Subject: Re: [PATCH 5/8] perf, tools: Support source line numbers in annotate
Date: Mon, 20 Oct 2014 20:17:55 +0200 [thread overview]
Message-ID: <20141020181755.GA5851@krava.brq.redhat.com> (raw)
In-Reply-To: <20141020180605.GC9913@krava.brq.redhat.com>
On Mon, Oct 20, 2014 at 08:06:05PM +0200, Jiri Olsa wrote:
SNIP
> > + if (dl->line_nr && annotate_browser__opts.show_linenr)
> > + printed = scnprintf(bf, sizeof(bf), "%*s %-5d ",
> > + ab->addr_width, " ", dl->line_nr);
> > + else
> > + printed = scnprintf(bf, sizeof(bf), "%*s ",
> > ab->addr_width, " ");
> > slsmg_write_nstring(bf, printed);
> > slsmg_write_nstring(dl->line, width - printed - pcnt_width + 1);
> > @@ -733,6 +738,7 @@ static int annotate_browser__run(struct annotate_browser *browser,
> > "o Toggle disassembler output/simplified view\n"
> > "s Toggle source code view\n"
> > "/ Search string\n"
> > + "k Toggle line numbers\n"
>
> extra tab --------^^^^^^ making the text misaligned in the help box
also by pressing 'k' the current line jumps to
the hottest line, which does not seem right
jirka
next prev parent reply other threads:[~2014-10-20 18:18 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-26 23:37 Implement lbr-as-callgraph v10 Andi Kleen
2014-09-26 23:37 ` [PATCH 1/8] perf, tools: Support handling complete branch stacks as histograms Andi Kleen
2014-10-20 7:54 ` Jiri Olsa
2014-10-20 10:10 ` Jiri Olsa
2014-10-22 1:03 ` Namhyung Kim
2014-11-11 23:31 ` Andi Kleen
2014-11-17 6:23 ` Namhyung Kim
2014-11-18 2:08 ` Andi Kleen
2014-09-26 23:37 ` [PATCH 2/8] perf, tools: Add --branch-history option to report Andi Kleen
2014-10-20 7:54 ` Jiri Olsa
2014-10-20 17:51 ` Jiri Olsa
2014-10-22 1:26 ` Namhyung Kim
2014-11-12 0:05 ` Andi Kleen
2014-11-17 6:31 ` Namhyung Kim
2014-11-18 2:01 ` Andi Kleen
2014-09-26 23:37 ` [PATCH 3/8] perf, tools: Enable printing the srcline in the history Andi Kleen
2014-10-20 17:57 ` Jiri Olsa
2014-09-26 23:37 ` [PATCH 4/8] perf, tools: Only print base source file for srcline Andi Kleen
2014-09-26 23:37 ` [PATCH 5/8] perf, tools: Support source line numbers in annotate Andi Kleen
2014-10-20 18:06 ` Jiri Olsa
2014-10-20 18:17 ` Jiri Olsa [this message]
2014-11-12 0:36 ` Andi Kleen
2014-09-26 23:37 ` [PATCH 6/8] tools, perf: Make get_srcline fall back to sym+offset Andi Kleen
2014-09-26 23:37 ` [PATCH 7/8] tools, perf: Make srcline output address with -v Andi Kleen
2014-10-20 18:20 ` Jiri Olsa
2014-09-26 23:37 ` [PATCH 8/8] tools, perf: Add asprintf replacement Andi Kleen
2014-10-20 18:28 ` Jiri Olsa
2014-10-20 19:13 ` Geert Uytterhoeven
2014-10-20 19:21 ` Jiri Olsa
2014-10-20 19:33 ` Geert Uytterhoeven
-- strict thread matches above, loose matches on Subject: below --
2014-09-15 23:54 Implement lbr-as-callgraph v9 Andi Kleen
2014-09-15 23:54 ` [PATCH 5/8] perf, tools: Support source line numbers in annotate Andi Kleen
2014-03-11 1:05 Implement lbr-as-callgraph v5 Andi Kleen
2014-03-11 1:05 ` [PATCH 5/8] perf, tools: Support source line numbers in annotate Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141020181755.GA5851@krava.brq.redhat.com \
--to=jolsa@redhat.com \
--cc=acme@kernel.org \
--cc=ak@linux.intel.com \
--cc=andi@firstfloor.org \
--cc=linux-kernel@vger.kernel.org \
--cc=namhyung@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome