From: Mark Brown <broonie@kernel.org>
To: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
Cc: Doug Anderson <dianders@chromium.org>,
Kukjin Kim <kgene.kim@samsung.com>,
Lee Jones <lee.jones@linaro.org>,
Tomasz Figa <tomasz.figa@gmail.com>,
Chanwoo Choi <cw00.choi@samsung.com>,
linux-samsung-soc <linux-samsung-soc@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Chris Zhong <zyw@rock-chips.com>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>
Subject: Re: [PATCH v2 2/2] ARM: EXYNOS: Call regulator core suspend prepare and finish functions
Date: Mon, 20 Oct 2014 20:56:41 +0100 [thread overview]
Message-ID: <20141020195641.GT18557@sirena.org.uk> (raw)
In-Reply-To: <544567A1.2060006@collabora.co.uk>
[-- Attachment #1: Type: text/plain, Size: 908 bytes --]
On Mon, Oct 20, 2014 at 09:50:57PM +0200, Javier Martinez Canillas wrote:
> On 10/20/2014 07:36 PM, Doug Anderson wrote:
> > I guess I was just trying to follow the suggestion that was in the
> > regulator code:
> > http://lxr.free-electrons.com/source/drivers/regulator/core.c#L3699
> > that says "This will usually be called by machine suspend code prior
> > to supending."
> I see, but still I feel as if it may be a lot of duplication since most
> platforms will likely want to call the regulator core suspend prepare
Note that architectures are an example of a platform. It really depends
what's responsible for final poweroff, we want this called as late as we
possibly can.
> and finish functions. Maybe it can be added as a Kconfig option so each
> platform can choose at the config level if they want those to be called?
No, that's obviously not going to do anything useful for multiplatform.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
next prev parent reply other threads:[~2014-10-20 19:57 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-16 10:13 [PATCH v2 0/2] ARM: EXYNOS: Call regulator suspend prepare/finish Javier Martinez Canillas
2014-10-16 10:13 ` [PATCH v2 1/2] Revert "mfd: sec-core: Prepare regulators for suspend state to reduce power-consumption" Javier Martinez Canillas
2014-10-16 10:13 ` [PATCH v2 2/2] ARM: EXYNOS: Call regulator core suspend prepare and finish functions Javier Martinez Canillas
2014-10-16 23:35 ` Chanwoo Choi
2014-10-20 16:26 ` Doug Anderson
2014-10-20 16:58 ` Javier Martinez Canillas
2014-10-20 17:36 ` Doug Anderson
2014-10-20 19:50 ` Javier Martinez Canillas
2014-10-20 19:56 ` Mark Brown [this message]
2014-10-20 20:10 ` Javier Martinez Canillas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141020195641.GT18557@sirena.org.uk \
--to=broonie@kernel.org \
--cc=cw00.choi@samsung.com \
--cc=dianders@chromium.org \
--cc=javier.martinez@collabora.co.uk \
--cc=kgene.kim@samsung.com \
--cc=lee.jones@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=rjw@rjwysocki.net \
--cc=tomasz.figa@gmail.com \
--cc=zyw@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome