From: Russell King - ARM Linux <linux@arm.linux.org.uk>
To: Kevin Hilman <khilman@kernel.org>
Cc: "jinkun.hong" <jinkun.hong@rock-chips.com>,
linus.walleij@linaro.org, linux-arm-kernel@lists.infradead.org,
Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>,
Grant Likely <grant.likely@linaro.org>,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
Randy Dunlap <rdunlap@infradead.org>,
linux-doc@vger.kernel.org, dianders@chromium.org,
Heiko Stuebner <heiko@sntech.de>,
linux-rockchip@lists.infradead.org,
Ulf Hansson <ulf.hansson@linaro.org>,
Jack Dai <jack.dai@rock-chips.com>
Subject: Re: [PATCH v4 1/3] power-domain: add power domain drivers for Rockchip platform
Date: Mon, 20 Oct 2014 22:40:29 +0100 [thread overview]
Message-ID: <20141020214029.GY27405@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <7hppdme8d6.fsf@deeprootsystems.com>
On Mon, Oct 20, 2014 at 02:31:17PM -0700, Kevin Hilman wrote:
> "jinkun.hong" <jinkun.hong@rock-chips.com> writes:
> > + spin_lock_irqsave(&pd->idle_lock, flags);
> > + val = (idle) ? mask : 0;
> > + regmap_update_bits(pd->regmap_pmu, REQ_OFFSET, mask, val);
> > + dsb();
>
> A summary of the locking and barriers here (or in changelog) would be
> helpful for reviewers to verify you're protecting what you need to
> protect.
It's also worth saying that the Linux specific barrier names should be
used unless there is a pressing reason to use the ARM specific barrier
names.
--
FTTC broadband for 0.8mile line: currently at 9.5Mbps down 400kbps up
according to speedtest.net.
next prev parent reply other threads:[~2014-10-20 21:41 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-20 9:03 [PATCH v4 0/3] ARM: rk3288 : Add PM Domain support jinkun.hong
2014-10-20 9:03 ` [PATCH v4 1/3] power-domain: add power domain drivers for Rockchip platform jinkun.hong
2014-10-20 9:09 ` Varka Bhadram
2014-10-20 21:31 ` Kevin Hilman
2014-10-20 21:40 ` Russell King - ARM Linux [this message]
2014-10-22 3:40 ` Hong jinkun
2014-10-20 9:03 ` [PATCH v4 2/3] dt-bindings: add document of Rockchip power domain jinkun.hong
2014-10-20 9:03 ` [PATCH v4 3/3] ARM: dts: add rk3288 power-domain node jinkun.hong
2014-10-20 21:32 ` [PATCH v4 0/3] ARM: rk3288 : Add PM Domain support Kevin Hilman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141020214029.GY27405@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=galak@codeaurora.org \
--cc=grant.likely@linaro.org \
--cc=heiko@sntech.de \
--cc=ijc+devicetree@hellion.org.uk \
--cc=jack.dai@rock-chips.com \
--cc=jinkun.hong@rock-chips.com \
--cc=khilman@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=rdunlap@infradead.org \
--cc=robh+dt@kernel.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®