From: David Miller <davem@davemloft.net>
To: sasha.levin@oracle.com
Cc: a.ryabinin@samsung.com, pablo@netfilter.org, mschmidt@redhat.com,
akpm@linux-foundation.org, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org
Subject: Re: [PATCH] netlink: don't copy over empty attribute data
Date: Tue, 21 Oct 2014 21:39:08 -0400 (EDT) [thread overview]
Message-ID: <20141021.213908.1088381802543942481.davem@davemloft.net> (raw)
In-Reply-To: <1413924669-26732-1-git-send-email-sasha.levin@oracle.com>
From: Sasha Levin <sasha.levin@oracle.com>
Date: Tue, 21 Oct 2014 16:51:09 -0400
> netlink uses empty data to seperate different levels. However, we still
> try to copy that data from a NULL ptr using memcpy, which is an undefined
> behaviour.
>
> Signed-off-by: Sasha Levin <sasha.levin@oracle.com>
This isn't a POSIX C library, this it the Linux kernel, and as such
we can make sure none of our memcpy() implementations try to access
any bytes if the given length is NULL.
And to be quite honest, there is no benefit whatsoever nor even the
possibility of using that "undefined behavior" flexibility to do
anthing. This is because every memcpy() implementation must be sure
not to access past the end of either source or destination buffer.
And the one and only way to do that is to respect the length.
I'm not applying this, because the basis for which this is claimed
to be a bug fix is quite bogus in my opinion.
Sorry.
next prev parent reply other threads:[~2014-10-22 1:39 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-21 20:51 Sasha Levin
2014-10-22 1:39 ` David Miller [this message]
2014-10-22 2:19 ` Sasha Levin
2014-10-22 6:15 ` David Miller
2014-10-26 23:32 ` Sasha Levin
2014-10-27 2:03 ` David Miller
2014-10-27 14:42 ` Sasha Levin
2014-10-27 16:46 ` Andrey Ryabinin
2014-10-22 8:55 ` David Laight
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141021.213908.1088381802543942481.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=a.ryabinin@samsung.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mschmidt@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=pablo@netfilter.org \
--cc=sasha.levin@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®