From: Seth Jennings <sjenning@redhat.com>
To: Josh Poimboeuf <jpoimboe@redhat.com>
Cc: Jiri Kosina <jkosina@suse.cz>,
Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>,
Anil S Keshavamurthy <anil.s.keshavamurthy@intel.com>,
Ananth N Mavinakayanahalli <ananth@in.ibm.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] kprobes: add kprobe_is_function_probed()
Date: Wed, 22 Oct 2014 09:03:35 -0500 [thread overview]
Message-ID: <20141022140335.GB5748@cerebellum.variantweb.net> (raw)
In-Reply-To: <20141022024032.GA8719@treble.redhat.com>
On Tue, Oct 21, 2014 at 09:40:32PM -0500, Josh Poimboeuf wrote:
> On Tue, Oct 21, 2014 at 11:25:56PM +0200, Jiri Kosina wrote:
> > On Tue, 21 Oct 2014, Josh Poimboeuf wrote:
> > >
> > > I'm guessing kGraft doesn't have the address + length? I think you
> > > could call kallsyms_lookup() to get both values.
> > >
> > > Maybe we should see what our unified live patching code ends up looking
> > > like before deciding what interface(s) we need here?
> >
> > Yes, that probably makes sense indeed. I am talking to David Miller wrt.
> > mailinglist creation on vger.kernel.org as we speak, hopefully it'll
> > materialize soon.
>
> Ok, thanks! Seth is currently slaving away on the code :-)
Yes, I am :) Let me know if this impacts the information we need to
pass via the *_register() call to the core module.
Currently, I pass the old function name (char *), new function pointer
(void *), and the old_addr (optional, unsigned long). The old_addr
serves to identify the old function by address instead of name if that
information is provided.
Thanks,
Seth
next prev parent reply other threads:[~2014-10-22 14:03 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-21 15:48 Jiri Kosina
2014-10-21 16:43 ` Josh Poimboeuf
2014-10-21 20:19 ` Jiri Kosina
2014-10-21 21:14 ` Josh Poimboeuf
2014-10-21 21:25 ` Jiri Kosina
2014-10-22 2:40 ` Josh Poimboeuf
2014-10-22 14:03 ` Seth Jennings [this message]
2014-10-21 16:48 ` Ananth N Mavinakayanahalli
2014-10-22 2:30 ` Masami Hiramatsu
2014-10-22 6:02 ` Jiri Kosina
2014-10-22 6:54 ` Masami Hiramatsu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141022140335.GB5748@cerebellum.variantweb.net \
--to=sjenning@redhat.com \
--cc=ananth@in.ibm.com \
--cc=anil.s.keshavamurthy@intel.com \
--cc=jkosina@suse.cz \
--cc=jpoimboe@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=masami.hiramatsu.pt@hitachi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®