From: Russell King - ARM Linux <linux@arm.linux.org.uk>
To: Mathieu Poirier <mathieu.poirier@linaro.org>
Cc: Catalin Marinas <catalin.marinas@arm.com>,
stefano.stabellini@eu.citrix.com,
ezequiel.garcia@free-electrons.com,
Liviu Dudau <Liviu.Dudau@arm.com>,
Thomas Petazzoni <thomas.petazzoni@free-electrons.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ARM: supplementing IO accessors with 64 bit capability
Date: Wed, 22 Oct 2014 18:19:42 +0100 [thread overview]
Message-ID: <20141022171942.GC27405@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <CANLsYkwGtB0=VDFa-p11AGFA1XLjgGQGLa-U4WYtSs7-pHtVdw@mail.gmail.com>
On Wed, Oct 22, 2014 at 06:22:09PM +0200, Mathieu Poirier wrote:
> I had this conversation with a colleague who reviewed the work. If
> the architecture is < 5 the __raw_ versions aren't included and the
> compiler won't complain until someone tries to use the macros. We
> achieve the same result - the macros aren't accessible when the
> architecture doesn't support it - while saving an #if condition in the
> file.
>
> I'm not strongly opinionated on this - I can enclose the macros in an
> #if statement.
What you're missing is that some driver may test for their presence by
doing:
#ifndef readq_relaxed
... do something else
which would now break as a detection method, as the macro is always
defined no matter whether it's present or not.
--
FTTC broadband for 0.8mile line: currently at 9.5Mbps down 400kbps up
according to speedtest.net.
next prev parent reply other threads:[~2014-10-22 17:19 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-22 16:06 mathieu.poirier
2014-10-22 16:11 ` Russell King - ARM Linux
2014-10-22 16:22 ` Mathieu Poirier
2014-10-22 17:19 ` Russell King - ARM Linux [this message]
2014-10-22 17:55 ` Mathieu Poirier
2014-10-22 16:44 ` Catalin Marinas
2014-10-22 19:10 ` Mathieu Poirier
2014-10-24 9:28 ` Catalin Marinas
2014-10-24 15:05 ` Mathieu Poirier
2014-10-24 16:16 ` Catalin Marinas
2014-10-24 17:54 ` Mathieu Poirier
2014-10-27 15:54 ` Will Deacon
2014-10-27 22:14 ` Mathieu Poirier
2014-10-28 12:23 ` Will Deacon
2014-10-23 19:47 ` Nicolas Pitre
2014-10-23 19:51 ` Russell King - ARM Linux
2014-10-23 20:15 ` Nicolas Pitre
2014-10-24 10:37 ` Arnd Bergmann
2014-10-24 9:23 ` Catalin Marinas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141022171942.GC27405@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=Liviu.Dudau@arm.com \
--cc=catalin.marinas@arm.com \
--cc=ezequiel.garcia@free-electrons.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.poirier@linaro.org \
--cc=stefano.stabellini@eu.citrix.com \
--cc=thomas.petazzoni@free-electrons.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®