From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752785AbaJYVFz (ORCPT ); Sat, 25 Oct 2014 17:05:55 -0400 Received: from shards.monkeyblade.net ([149.20.54.216]:33786 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751366AbaJYVFy (ORCPT ); Sat, 25 Oct 2014 17:05:54 -0400 Date: Sat, 25 Oct 2014 17:05:51 -0400 (EDT) Message-Id: <20141025.170551.1379400739319408704.davem@davemloft.net> To: geert@linux-m68k.org Cc: isubramanian@apm.com, kchudgar@apm.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3] drivers: net: xgene: Rewrite buggy loop in xgene_enet_ecc_init() From: David Miller In-Reply-To: <1414052753-10183-1-git-send-email-geert@linux-m68k.org> References: <1414052753-10183-1-git-send-email-geert@linux-m68k.org> X-Mailer: Mew version 6.5 on Emacs 24.1 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=iso-8859-7 X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.7 (shards.monkeyblade.net [149.20.54.216]); Sat, 25 Oct 2014 14:05:53 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by nfs id s9PL61sh030072 From: Geert Uytterhoeven Date: Thu, 23 Oct 2014 10:25:53 +0200 > drivers/net/ethernet/apm/xgene/xgene_enet_sgmac.c: In function xgene_enet_ecc_init: > drivers/net/ethernet/apm/xgene/xgene_enet_sgmac.c:126: warning: data may be used uninitialized in this function > > Depending on the arbitrary value on the stack, the loop may terminate > too early, and cause a bogus -ENODEV failure. > > Signed-off-by: Geert Uytterhoeven > --- > v3: > - Use "do { ... } while (...);" instead of "for (...) { ... }", > v2: > - Rewrite the loop instead of pre-initializing data. Applied, thank you. {.n++%ݶw{.n+{G{ayʇڙ,jfhz_(階ݢj"mG?&~iOzv^m ?I