From: David Miller Date: Mon, 27 Oct 2014 18:52:11 -0400 (EDT) > From: Roberto Medina > Date: Thu, 23 Oct 2014 19:10:00 +0200 > >> From: Roberto Medina >> >> Several warnings and errors of coding style errors corrected. >> >> Signed-off-by: Roberto Medina > > Applied, thanks. Wait, are you serious, you didn't even compile test this change? For real? In file included from drivers/net/ethernet/realtek/atp.c:146:0: drivers/net/ethernet/realtek/atp.h:79:15: error: expected ¡;¢, identifier or ¡(¢ before ¡unsigned¢ static inline unsigned char inbyte(unsigned short port) ^ drivers/net/ethernet/realtek/atp.h:79:15: error: ¡inline¢ in empty declaration Don't even submit changes meant for inclusion if you're not even willing to build test them. And I'm very serious about this. ÿôèº{.nÇ+‰·Ÿ®‰­†+%ŠËÿ±éݶ¥Šwÿº{.nÇ+‰·¥Š{±þG«�éÿŠ{ayºʇڙë,j­¢f£¢·hš�ï�êÿ‘êçz_è®(­éšŽŠÝ¢j"�ú¶m§ÿÿ¾«þG«�éÿ¢¸?™¨è­Ú&£ø§~�á¶iO•æ¬z·švØ^¶m§ÿÿà ÿ¶ìÿ¢¸?–I¥