From: Guenter Roeck <linux@roeck-us.net>
To: "John W. Linville" <linville@tuxdriver.com>
Cc: Hauke Mehrtens <hauke@hauke-m.de>,
linux-wireless@vger.kernel.org, zajec5@gmail.com,
arend@broadcom.com, arnd@arndb.de, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] bcma: fix build when CONFIG_OF_ADDRESS is not set
Date: Mon, 27 Oct 2014 08:42:51 -0700 [thread overview]
Message-ID: <20141027154251.GB7677@roeck-us.net> (raw)
In-Reply-To: <20141027151509.GA19976@tuxdriver.com>
On Mon, Oct 27, 2014 at 11:15:09AM -0400, John W. Linville wrote:
> Yes, I have it queued. Things have been delayed due to my recent
> travels, etc.
>
Thanks!
Guenter
> On Sat, Oct 25, 2014 at 01:36:53PM -0700, Guenter Roeck wrote:
> > On Thu, Oct 09, 2014 at 11:39:41PM +0200, Hauke Mehrtens wrote:
> > > Commit 2101e533f41a ("bcma: register bcma as device tree driver")
> > > introduces a hard dependency on OF_ADDRESS into the bcma driver.
> > > OF_ADDRESS is specifically disabled for the sparc architecture.
> > > This results in the following error when building sparc64:allmodconfig.
> > >
> > > drivers/bcma/main.c: In function 'bcma_of_find_child_device':
> > > drivers/bcma/main.c:150:3: error: implicit declaration of function 'of_translate_address'
> > >
> > > Fixes: 2101e533f41a ("bcma: register bcma as device tree driver")
> > > Reported-by: Guenter Roeck <linux@roeck-us.net>
> > > Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de>
> >
> > The upstream kernel still does not include this patch, and the sparc64 build
> > is still broken.
> >
> > Is this patch on its way upstream ?
> >
> > Guenter
> >
> > > ---
> > > drivers/bcma/main.c | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/drivers/bcma/main.c b/drivers/bcma/main.c
> > > index d1656c2..1000955 100644
> > > --- a/drivers/bcma/main.c
> > > +++ b/drivers/bcma/main.c
> > > @@ -132,7 +132,7 @@ static bool bcma_is_core_needed_early(u16 core_id)
> > > return false;
> > > }
> > >
> > > -#ifdef CONFIG_OF
> > > +#if defined(CONFIG_OF) && defined(CONFIG_OF_ADDRESS)
> > > static struct device_node *bcma_of_find_child_device(struct platform_device *parent,
> > > struct bcma_device *core)
> > > {
> > > --
> > > 1.9.1
> > >
> > > --
> > > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> > > the body of a message to majordomo@vger.kernel.org
> > > More majordomo info at http://vger.kernel.org/majordomo-info.html
> > > Please read the FAQ at http://www.tux.org/lkml/
> > >
> > >
> >
>
> --
> John W. Linville Someday the world will need a hero, and you
> linville@tuxdriver.com might be all we have. Be ready.
next prev parent reply other threads:[~2014-10-27 15:43 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-09 16:41 [PATCH] bcma: Add dependency on OF_ADDRESS Guenter Roeck
2014-10-09 16:54 ` Rafał Miłecki
2014-10-09 17:15 ` Guenter Roeck
2014-10-09 17:15 ` Arend van Spriel
2014-10-09 17:18 ` Arend van Spriel
2014-10-09 17:29 ` Guenter Roeck
2014-10-09 18:28 ` Hauke Mehrtens
2014-10-09 19:25 ` Guenter Roeck
2014-10-09 21:48 ` Hauke Mehrtens
2014-10-09 21:57 ` Guenter Roeck
2014-10-10 9:30 ` Arend van Spriel
2014-10-09 21:39 ` [PATCH] bcma: fix build when CONFIG_OF_ADDRESS is not set Hauke Mehrtens
2014-10-09 21:46 ` Guenter Roeck
2014-10-25 20:36 ` Guenter Roeck
2014-10-27 15:15 ` John W. Linville
2014-10-27 15:42 ` Guenter Roeck [this message]
2014-10-09 17:21 ` [PATCH] bcma: Add dependency on OF_ADDRESS Guenter Roeck
2014-10-10 0:24 ` Julian Calaby
2014-10-10 4:32 ` David Miller
2014-10-09 17:28 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141027154251.GB7677@roeck-us.net \
--to=linux@roeck-us.net \
--cc=arend@broadcom.com \
--cc=arnd@arndb.de \
--cc=hauke@hauke-m.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=zajec5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®