From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753755AbaJ1KsQ (ORCPT ); Tue, 28 Oct 2014 06:48:16 -0400 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:52780 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752800AbaJ1KsP (ORCPT ); Tue, 28 Oct 2014 06:48:15 -0400 Date: Tue, 28 Oct 2014 10:47:42 +0000 From: Mark Brown To: Nicolin Chen Cc: linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, alsa-devel@alsa-project.org Message-ID: <20141028104742.GP18557@sirena.org.uk> References: <1414202637-18929-1-git-send-email-nicoleotsuka@gmail.com> <20141028001904.GH18557@sirena.org.uk> <20141028042603.GA5548@Asurada> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="scYsJfBjqkrBfg1Z" Content-Disposition: inline In-Reply-To: <20141028042603.GA5548@Asurada> X-Cookie: FORCE YOURSELF TO RELAX! User-Agent: Mutt/1.5.23 (2014-03-12) X-SA-Exim-Connect-IP: 94.175.94.161 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [PATCH] ASoC: fsl_asrc: Add reg_defaults for regmap to fix kernel dump X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on mezzanine.sirena.org.uk) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --scYsJfBjqkrBfg1Z Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, Oct 27, 2014 at 09:26:26PM -0700, Nicolin Chen wrote: > On Tue, Oct 28, 2014 at 12:19:04AM +0000, Mark Brown wrote: > > It's not a bug, it's not reasonable to default allocations to atomic and > > we can't really tell what context we're in. Anything used inside a > > heavily locked path should either have a default provided or arrange for > > a prior write to set up the cache. > I've a little trouble to understand the prior write over here. Inside my > probe() there's a register_init() call which has a set of regmap_write(). > And then the first regmap_write() results the dump. Does that mean this > regmap_write() isn't prior write? If so, how should I do if not setting Oh, bother. We fixed things so that we're now always running with the spinlock held... never mind. > default values here -- Some IPs may have default value 0 for registers. > And this would make reg_defaults tedious since there's nothing special > to assign. Write a small script then, or a little bit of code to create the defaults dynamically. > And actually I remember I haven't seen any dump when I sent the initial > patch for the whole ASRC driver but it manifested last month. I thought > it might be a partially-merging issue and it would be fixed after merge > window's done..... Nothing has changed here for a while as far as I remember. --scYsJfBjqkrBfg1Z Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBAgAGBQJUT3RNAAoJECTWi3JdVIfQ6dgH/31xUY+Mj0t8ZJ640hvt2+hz 02CP6IhL9gVdQ0/K6+AupVIIln9sbR5Ys9PWnZShGmcULb99c4wcwuo0pQhI3He8 00TCixzko3Q3rFo3Hbs5GaxlmUpUOlki3n5O34rZ4whOHqWuBk7MVEB/crrJHANS M3FzS0IB5wymEWPnr2PYXwQi52JNcSYhXOHVqmhnJJJPiFut1otsqo4qAaSjLmxz MRw0qSFWwuT0YdRK8ku0jvpZgOsyC2uyRR9ZIRvX4sufNDXgv18spfATbk5DtxSy 1vbZETpugd6Bu/B3Tn97rv/M2NIDEtNN5txJEZpmG277LPjiq1ujx1vuGpUogVs= =YnuJ -----END PGP SIGNATURE----- --scYsJfBjqkrBfg1Z--