From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753881AbaJ1Rc5 (ORCPT ); Tue, 28 Oct 2014 13:32:57 -0400 Received: from cdptpa-outbound-snat.email.rr.com ([107.14.166.228]:44793 "EHLO cdptpa-oedge-vip.email.rr.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752593AbaJ1Rcz (ORCPT ); Tue, 28 Oct 2014 13:32:55 -0400 Date: Tue, 28 Oct 2014 13:32:53 -0400 From: Steven Rostedt To: Joe Perches Cc: Brian Norris , Al Viro , Petr Mladek , Andrew Morton , Linus Torvalds , David Woodhouse , linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 7/7] docg3: Fix miuse of seq_printf return value Message-ID: <20141028133253.223e47f7@gandalf.local.home> In-Reply-To: <1414517260.6643.21.camel@perches.com> References: <20140929124246.3e39dac8@gandalf.local.home> <20141022082916.GD16128@brian-ubuntu> <20141028111301.22481f2a@gandalf.local.home> <1414511877.6643.12.camel@perches.com> <20141028120552.63c2324c@gandalf.local.home> <1414517260.6643.21.camel@perches.com> X-Mailer: Claws Mail 3.10.1 (GTK+ 2.24.25; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-RR-Connecting-IP: 107.14.168.142:25 X-Cloudmark-Score: 0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 28 Oct 2014 10:27:40 -0700 Joe Perches wrote: > On Tue, 2014-10-28 at 12:05 -0400, Steven Rostedt wrote: > > On Tue, 28 Oct 2014 08:57:57 -0700 > > Joe Perches wrote: > > > > > On Tue, 2014-10-28 at 11:13 -0400, Steven Rostedt wrote: > > > > I'm going to be working on changes to remove the return value of > > > > seq_printf() and friends. > > > > > > I'm sure you know all of this, but for anyone else: > > > > > > This doesn't need to be done in a single pass. > > > > Yeah, I took a look at all the places, and I've decided to take it off > > in chunks. I'm starting with the ones you posted, and will try to get > > acks for them. And then go after other chunks as I have time. > > > > I would like to get this done before I do my merge of trace_seq and > > seq_file, but I'm thinking I may have to do that in parallel. > > I think the most important thing is to get the > seq_is_overflown (or seq_has_overflowed or whatever > other name is chosen) function added then the rest > of the patches can be applied whenever maintainers > (or Andrew or trivial or ...) pick them up. I can get that in without much of an issue. But the merge of trace_seq and seq_file would be easier if I didn't have to worry about return values. Which is why I want to get this in quickly. -- Steve