mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Qais Yousef <qais.yousef@imgtec.com>
Cc: linux-kernel@vger.kernel.org, Arnd Bergmann <arnd@arndb.de>,
	alsa-devel@alsa-project.org
Subject: Re: [PATCH 09/11] drivers: char: axd: add sysfs setup files
Date: Tue, 28 Oct 2014 22:12:55 +0800	[thread overview]
Message-ID: <20141028141255.GC18384@kroah.com> (raw)
In-Reply-To: <1414495589-8579-10-git-send-email-qais.yousef@imgtec.com>

On Tue, Oct 28, 2014 at 11:26:27AM +0000, Qais Yousef wrote:
> +/* Control Device Sysfs Attributes */
> +/* version */
> +static ssize_t show_version(struct device *dev, struct device_attribute *attr,
> +							char *buf)
> +{
> +	struct axd_cmd *cmd = (struct axd_cmd *)dev->platform_data;
> +	int major, minor, patch;
> +
> +	axd_cmd_get_version(cmd, &major, &minor, &patch);
> +	return sprintf(buf, "%u.%u.%u\n", major, minor, patch);
> +}
> +static DEVICE_ATTR(version, RD_PERMS, show_version, NULL);

DEVICE_ATTR_RO() please.  Same for all other instances, you should never
use DEVICE_ATTR() anymore.

thanks,

greg k-h

  parent reply	other threads:[~2014-10-28 14:14 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-28 11:26 [PATCH 00/11] Add AXD Audio Processing IP driver Qais Yousef
2014-10-28 11:26 ` [PATCH 01/11] MAINTANERS: Add AXD as a supported driver Qais Yousef
2014-10-29  5:42   ` [alsa-devel] " Vinod Koul
2014-10-28 11:26 ` [PATCH 02/11] dt: bindings: add AXD Audio Processing IP binding document Qais Yousef
2014-10-28 11:26 ` [PATCH 03/11] drivers: char: add AXD Audio Processing IP driver Qais Yousef
2014-10-28 14:10   ` Greg Kroah-Hartman
2014-10-28 14:36     ` Qais Yousef
2014-10-28 14:50       ` Greg Kroah-Hartman
2014-10-29  5:33   ` [alsa-devel] " Vinod Koul
2014-10-28 11:26 ` [PATCH 04/11] drivers: char: axd: add fw binary header manipulation files Qais Yousef
2014-10-28 11:26 ` [PATCH 05/11] drivers: char: axd: add buffers " Qais Yousef
2014-10-28 11:26 ` [PATCH 06/11] drivers: char: axd: add basic files for sending/receiving axd cmds Qais Yousef
2014-10-28 11:26 ` [PATCH 07/11] drivers: char: axd: add cmd interfce helper functions Qais Yousef
2014-10-29  5:38   ` [alsa-devel] " Vinod Koul
2014-10-28 11:26 ` [PATCH 08/11] drivers: char: axd: add low level AXD platform setup files Qais Yousef
2014-10-28 11:26 ` [PATCH 09/11] drivers: char: axd: add sysfs " Qais Yousef
2014-10-28 14:11   ` Greg Kroah-Hartman
2014-10-28 14:38     ` Qais Yousef
2014-10-28 14:12   ` Greg Kroah-Hartman [this message]
2014-10-28 14:39     ` Qais Yousef
2014-10-29  5:41   ` [alsa-devel] " Vinod Koul
2014-10-28 11:26 ` [PATCH 10/11] drivers: char: axd: add ts interface file Qais Yousef
2014-10-28 11:26 ` [PATCH 11/11] drivers: char: axd: add Kconfig and Makefile Qais Yousef
2014-10-28 11:55 ` [PATCH 00/11] Add AXD Audio Processing IP driver Clemens Ladisch
2014-10-28 13:18   ` Qais Yousef
2014-10-28 14:13     ` Greg Kroah-Hartman
2014-10-28 15:05       ` Qais Yousef
2014-10-29  2:50         ` Greg Kroah-Hartman
2014-10-29  5:24           ` [alsa-devel] " Vinod Koul
2014-10-29 10:48             ` Qais Yousef
2014-10-29  5:20       ` Vinod Koul
2014-10-28 14:54     ` Lars-Peter Clausen
2014-10-28 15:33       ` Qais Yousef
2014-10-28 16:04         ` [alsa-devel] " Lars-Peter Clausen
2014-10-29  5:18     ` Vinod Koul
2014-10-29 15:06     ` Pierre-Louis Bossart
2014-10-28 12:06 ` Lars-Peter Clausen
2014-10-28 13:21   ` Qais Yousef

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141028141255.GC18384@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=alsa-devel@alsa-project.org \
    --cc=arnd@arndb.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=qais.yousef@imgtec.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome