Re: [PATCH v2 1/1] staging: skein: Removes skein_debug include

[Jason Cooper <jason@lakedaemon.net>]

Eric,

Much better.  One small nit below:

On Tue, Oct 28, 2014 at 06:44:31PM -0500, Eric Rost wrote:
> Removes skein_debug.h include since skein_debug.h is nonexistent.
> Removes unneeded debug empty macro defines and their uses.
> 
> Signed-off-by: Eric Rost <eric.rost@mybabylon.net>
> ---
>  drivers/staging/skein/skein_base.c  | 18 ------------------
>  drivers/staging/skein/skein_base.h  | 17 -----------------
>  drivers/staging/skein/skein_block.c | 30 +-----------------------------
>  3 files changed, 1 insertion(+), 64 deletions(-)
> 
...
> diff --git a/drivers/staging/skein/skein_block.c b/drivers/staging/skein/skein_block.c
> index 36b0b40..289bf13 100644
> --- a/drivers/staging/skein/skein_block.c
> +++ b/drivers/staging/skein/skein_block.c
...
> @@ -422,9 +409,6 @@ void skein_256_process_block(struct skein_256_ctx *ctx, const u8 *blk_ptr,
>  		X3 = w[3] + ks[3];
>  
>  		/* show starting state values */
> -		skein_show_r_ptr(BLK_BITS, &ctx->h, SKEIN_RND_KEY_INITIAL,
> -				 x_ptr);
> -

Please remove the comment here as well.

>  		blk_ptr += SKEIN_256_BLOCK_BYTES;
>  
>  		/* run the rounds */

Fix that up and please add my:

Reviewed-by: Jason Cooper <jason@lakedaemon.net>

to the next version (below your Signed-off-by:).

thx,

Jason.