From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933306AbaJ2OTB (ORCPT ); Wed, 29 Oct 2014 10:19:01 -0400 Received: from mga02.intel.com ([134.134.136.20]:17587 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932476AbaJ2OS7 (ORCPT ); Wed, 29 Oct 2014 10:18:59 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.04,810,1406617200"; d="scan'208";a="627659290" Date: Wed, 29 Oct 2014 22:18:55 +0800 From: Fengguang Wu To: Felipe Balbi Cc: Wei Yongjun , Julia Lawall , linux-usb@vger.kernel.org, LKML Subject: [PATCH] usb: gadget: fix ptr_ret.cocci warnings Message-ID: <20141029141855.GA9654@wfg-t540p.sh.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Heirloom mailx 12.5 6/20/10 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org drivers/usb/gadget/udc/r8a66597-udc.c:1849:1-3: WARNING: PTR_ERR_OR_ZERO can be used Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR Generated by: scripts/coccinelle/api/ptr_ret.cocci Signed-off-by: Fengguang Wu --- r8a66597-udc.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) --- a/drivers/usb/gadget/udc/r8a66597-udc.c +++ b/drivers/usb/gadget/udc/r8a66597-udc.c @@ -1846,10 +1846,7 @@ static int r8a66597_sudmac_ioremap(struc res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "sudmac"); r8a66597->sudmac_reg = devm_ioremap_resource(&pdev->dev, res); - if (IS_ERR(r8a66597->sudmac_reg)) - return PTR_ERR(r8a66597->sudmac_reg); - - return 0; + return PTR_ERR_OR_ZERO(r8a66597->sudmac_reg); } static int r8a66597_probe(struct platform_device *pdev)