From: Mark Brown <broonie@kernel.org>
To: Max Filippov <jcmvbkbc@gmail.com>
Cc: alsa-devel@alsa-project.org,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-xtensa@linux-xtensa.org" <linux-xtensa@linux-xtensa.org>,
LKML <linux-kernel@vger.kernel.org>, Takashi Iwai <tiwai@suse.de>,
Liam Girdwood <lgirdwood@gmail.com>,
Jaroslav Kysela <perex@perex.cz>,
Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>,
Grant Likely <grant.likely@linaro.org>
Subject: Re: [PATCH] ASoC: add xtensa xtfpga I2S interface and platform
Date: Wed, 29 Oct 2014 21:02:50 +0000 [thread overview]
Message-ID: <20141029210250.GM18557@sirena.org.uk> (raw)
In-Reply-To: <CAMo8BfJfRTo7puxeafyBnaGWhY38o6ktsSBugcSmSaMYUArcyw@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 836 bytes --]
On Wed, Oct 29, 2014 at 05:23:15PM +0300, Max Filippov wrote:
> On Tue, Oct 28, 2014 at 8:38 PM, Mark Brown <broonie@kernel.org> wrote:
> > On Tue, Oct 28, 2014 at 08:00:45PM +0300, Max Filippov wrote:
> >> > It's also about ensuring that the code is cleanly split up so that
> >> > someone can actually go in and add the required support later (and TBH
> >> Can you point me to an example of such split, so that I don't write it in
> >> an unusual way?
> > Essentially all drivers are split this way...
> But all of them have DMA registers and I2S registers completely separated,
> right? How do I share registers between pcm and i2s parts?
Just keep the code physically separate so the DMA bits are hanging off
the DMA operations and the interface setup bits are hanging off the DAI
operations rather than all mixed in together.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
next prev parent reply other threads:[~2014-10-29 21:03 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-27 19:07 Max Filippov
2014-10-27 19:32 ` Mark Brown
2014-10-27 20:38 ` Max Filippov
2014-10-28 15:42 ` Mark Brown
2014-10-28 17:00 ` Max Filippov
2014-10-28 17:38 ` Mark Brown
2014-10-28 18:11 ` Max Filippov
2014-10-28 21:34 ` Mark Brown
2014-10-29 14:19 ` Max Filippov
2014-10-29 14:23 ` Max Filippov
2014-10-29 21:02 ` Mark Brown [this message]
2014-10-29 21:10 ` Max Filippov
2014-10-29 21:16 ` Mark Brown
2014-10-28 15:58 ` [alsa-devel] " Lars-Peter Clausen
2014-10-28 16:04 ` Mark Brown
2014-10-28 16:39 ` Lars-Peter Clausen
2014-10-28 16:47 ` Takashi Iwai
2014-10-28 17:06 ` Mark Brown
2014-10-28 17:16 ` Max Filippov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141029210250.GM18557@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=grant.likely@linaro.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=jcmvbkbc@gmail.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-xtensa@linux-xtensa.org \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=perex@perex.cz \
--cc=robh+dt@kernel.org \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®