From: Alexis Berlemont <alexis.berlemont@gmail.com>
To: Jiri Olsa <jolsa@redhat.com>
Cc: linux-kernel@vger.kernel.org, dsahern@gmail.com,
mingo@redhat.com, a.p.zijlstra@chello.nl, paulus@samba.org,
acme@kernel.org, namhyung@kernel.org, mmarek@suse.cz,
Arnaldo Carvalho de Melo <acme@ghostprotocols.net>,
Ingo Molnar <mingo@elte.hu>,
Corey Ashford <cjashfor@linux.vnet.ibm.com>,
Frederic Weisbecker <fweisbec@gmail.com>,
Borislav Petkov <bp@alien8.de>,
linux-kbuild@vger.kernel.org,
Stephane Eranian <eranian@google.com>
Subject: Re: [PATCH v4 04/14] perf tools: Add kbuild support into Makefile.kbuild
Date: Thu, 30 Oct 2014 00:05:07 +0100 [thread overview]
Message-ID: <20141029230507.GA15701@marx-slim.home> (raw)
In-Reply-To: <20141029081603.GC3538@krava.brq.redhat.com>
Jiri Olsa wrote:
> On Sun, Oct 26, 2014 at 12:20:29AM +0200, Alexis Berlemont wrote:
> > From: Jiri Olsa <jolsa@redhat.com>
>
> SNIP
>
> > ---
> > tools/perf/Kbuild | 47 +++
> > tools/perf/Kconfig | 284 ++++++++++++++
> > tools/perf/Makefile.kbuild | 431 +++++++++++++++++++++
> > tools/perf/Makefile.perf | 2 +-
> > tools/perf/arch/Kbuild | 3 +
> > tools/perf/arch/arm/Kbuild | 2 +
> > tools/perf/arch/arm/Makefile | 14 -
> > tools/perf/arch/arm/tests/Kbuild | 2 +
> > tools/perf/arch/arm/util/Kbuild | 3 +
> > tools/perf/arch/arm64/Kbuild | 1 +
> > tools/perf/arch/arm64/Makefile | 7 -
> > tools/perf/arch/arm64/util/Kbuild | 2 +
> > tools/perf/arch/powerpc/Kbuild | 1 +
> > tools/perf/arch/powerpc/Makefile | 6 -
> > tools/perf/arch/powerpc/util/Kbuild | 3 +
> > tools/perf/arch/s390/Kbuild | 1 +
> > tools/perf/arch/s390/Makefile | 7 -
> > tools/perf/arch/s390/util/Kbuild | 2 +
> > tools/perf/arch/sh/Kbuild | 1 +
> > tools/perf/arch/sh/Makefile | 4 -
> > tools/perf/arch/sh/util/Kbuild | 1 +
> > tools/perf/arch/sparc/Kbuild | 1 +
> > tools/perf/arch/sparc/Makefile | 4 -
> > tools/perf/arch/sparc/util/Kbuild | 1 +
> > tools/perf/arch/x86/Kbuild | 1 +
> > tools/perf/arch/x86/tests/Kbuild | 3 +
> > tools/perf/{ => arch/x86}/tests/perf-time-to-tsc.c | 0
> > tools/perf/arch/x86/util/Kbuild | 5 +
> > tools/perf/bench/Kbuild | 12 +
> > tools/perf/builtin-cmds.h | 4 +
> > tools/perf/config/Makefile | 55 ++-
> > tools/perf/config/Makefile.fix-config | 104 +++++
> > tools/perf/config/Makefile.fix-legacy | 46 +++
> > tools/perf/config/defconfig | 54 +++
> > tools/perf/perf-sys.h | 4 +-
> > tools/perf/scripts/perl/Perf-Trace-Util/Kbuild | 6 +
> > tools/perf/scripts/python/Perf-Trace-Util/Kbuild | 5 +
> > tools/perf/tests/Kbuild | 38 ++
> > tools/perf/ui/Kbuild | 15 +
> > tools/perf/ui/browsers/Kbuild | 9 +
> > tools/perf/ui/gtk/Kbuild | 9 +
> > tools/perf/ui/stdio/Kbuild | 1 +
> > tools/perf/ui/tui/Kbuild | 4 +
> > tools/perf/util/Kbuild | 126 ++++++
> > tools/perf/util/PERF-VERSION-GEN | 4 +
> > tools/perf/util/generate-cmdlist.sh | 8 +-
> > tools/perf/util/scripting-engines/Kbuild | 11 +
> > tools/perf/util/setup.py | 8 +-
>
> so this patch took the perf Makefile (at that time) and changed it to
> use the kbuild.. but since that time the Makefile.perf came and many
> other changes, which need to be reflected in Makefile.kbuild
>
> I need to revisit the logic and split the change into more incremental
> patches (the patchset is too big)
>
> I can redo patches 2,3,4 and get back to you, sounds ok?
Of course.
Which changes in Makefile.perf do you have in mind ? I thought that
Makefile.kbuild was just supposed to build the few extra dependencies
(libtraceevent, etc.). I thought that I updated your original patch
accordingly with the changes before and after the add of
Makefile.perf.
Alexis.
next prev parent reply other threads:[~2014-10-29 23:07 UTC|newest]
Thread overview: 76+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-22 21:53 [PATCH 00/15] Kbuild for perf Alexis Berlemont
2014-09-22 21:53 ` [PATCH 01/15] kbuild: add support of custom paths for "auto.conf*" files Alexis Berlemont
2014-09-23 13:01 ` Michal Marek
2014-10-23 21:47 ` Alexis Berlemont
2014-10-23 21:55 ` [PATCH v2 00/14] Kbuild for perf Alexis Berlemont
2014-10-23 22:28 ` [PATCH v3 " Alexis Berlemont
2014-10-23 23:48 ` Arnaldo Carvalho de Melo
2014-10-24 12:39 ` Alexis Berlemont
2014-10-24 12:46 ` Arnaldo Carvalho de Melo
2014-10-25 22:20 ` [PATCH v4 " Alexis Berlemont
2014-10-27 22:37 ` Jiri Olsa
2014-10-28 23:54 ` Alexis Berlemont
2014-10-25 22:20 ` [PATCH v4 01/14] kbuild: add support of custom paths for "auto.conf*" files Alexis Berlemont
2014-10-25 22:20 ` [PATCH v4 02/14] perf tools: Kbuild builtin source related fixies Alexis Berlemont
2014-10-25 22:20 ` [PATCH v4 03/14] perf tools: Kbuild " Alexis Berlemont
2014-10-25 22:20 ` [PATCH v4 04/14] perf tools: Add kbuild support into Makefile.kbuild Alexis Berlemont
2014-10-29 8:16 ` Jiri Olsa
2014-10-29 23:05 ` Alexis Berlemont [this message]
2014-10-31 8:34 ` Jiri Olsa
2014-10-25 22:20 ` [PATCH v4 05/14] perf kbuild: remove Makefile.perf Alexis Berlemont
2014-10-25 22:20 ` [PATCH v4 06/14] perf kbuild: remove legacy tui/gui-related build variables Alexis Berlemont
2014-10-25 22:20 ` [PATCH v4 07/14] perf kbuild: remove legacy demangle-related " Alexis Berlemont
2014-10-25 22:20 ` [PATCH v4 08/14] perf kbuild: cross-compilation variables are now handled in Kconfig Alexis Berlemont
2014-10-25 22:20 ` [PATCH v4 09/14] perf kbuild: remove legacy misc build variables Alexis Berlemont
2014-10-25 22:20 ` [PATCH v4 10/14] perf kbuild: remove legacy libelf-related " Alexis Berlemont
2014-10-25 22:20 ` [PATCH v4 11/14] perf kbuild: remove legacy libdwarf-related " Alexis Berlemont
2014-10-25 22:20 ` [PATCH v4 12/14] perf kbuild: remove legacy script-related " Alexis Berlemont
2014-10-25 22:20 ` [PATCH v4 13/14] perf kbuild: final cosmetic changes Alexis Berlemont
2014-10-25 22:20 ` [PATCH v4 14/14] perf kbuild: add generated Kconfig build-test cases Alexis Berlemont
2014-10-23 22:28 ` [PATCH v3 01/14] kbuild: add support of custom paths for "auto.conf*" files Alexis Berlemont
2014-10-23 22:28 ` [PATCH v3 02/14] perf tools: Kbuild builtin source related fixies Alexis Berlemont
2014-10-23 22:28 ` [PATCH v3 03/14] perf tools: Kbuild " Alexis Berlemont
2014-10-23 22:28 ` [PATCH v3 04/14] perf tools: Add kbuild support into Makefile.kbuild Alexis Berlemont
2014-10-23 22:28 ` [PATCH v3 05/14] perf kbuild: remove Makefile.perf Alexis Berlemont
2014-10-23 22:28 ` [PATCH v3 06/14] perf kbuild: remove legacy tui/gui-related build variables Alexis Berlemont
2014-10-23 22:28 ` [PATCH v3 07/14] perf kbuild: remove legacy demangle-related " Alexis Berlemont
2014-10-23 22:28 ` [PATCH v3 08/14] perf kbuild: cross-compilation variables are now handled in Kconfig Alexis Berlemont
2014-10-23 22:28 ` [PATCH v3 09/14] perf kbuild: remove legacy misc build variables Alexis Berlemont
2014-10-23 22:28 ` [PATCH v3 10/14] perf kbuild: remove legacy libelf-related " Alexis Berlemont
2014-10-23 22:28 ` [PATCH v3 11/14] perf kbuild: remove legacy libdwarf-related " Alexis Berlemont
2014-10-23 22:28 ` [PATCH v3 12/14] perf kbuild: remove legacy script-related " Alexis Berlemont
2014-10-23 22:28 ` [PATCH v3 13/14] perf kbuild: final cosmetic changes Alexis Berlemont
2014-10-23 22:28 ` [PATCH v3 14/14] perf kbuild: add generated Kconfig build-test cases Alexis Berlemont
2015-05-31 19:22 ` Ulf Magnusson
2014-10-23 21:55 ` [PATCH v2 01/14] kbuild: add support of custom paths for "auto.conf*" files Alexis Berlemont
2014-10-23 21:56 ` [PATCH v2 02/14] perf tools: Kbuild builtin source related fixies Alexis Berlemont
2014-10-23 21:56 ` [PATCH v2 03/14] perf tools: Kbuild " Alexis Berlemont
2014-10-23 21:56 ` [PATCH v2 04/14] perf tools: Add kbuild support into Makefile.kbuild Alexis Berlemont
2014-10-23 21:56 ` [PATCH v2 05/14] perf kbuild: remove Makefile.perf Alexis Berlemont
2014-10-23 21:56 ` [PATCH v2 06/14] perf kbuild: remove legacy tui/gui-related build variables Alexis Berlemont
2014-10-23 21:56 ` [PATCH v2 07/14] perf kbuild: remove legacy demangle-related " Alexis Berlemont
2014-10-23 21:56 ` [PATCH v2 08/14] perf kbuild: cross-compilation variables are now handled in Kconfig Alexis Berlemont
2014-10-23 21:56 ` [PATCH v2 09/14] perf kbuild: remove legacy misc build variables Alexis Berlemont
2014-10-23 21:56 ` [PATCH v2 10/14] perf kbuild: remove legacy libelf-related " Alexis Berlemont
2014-10-23 21:56 ` [PATCH v2 11/14] perf kbuild: remove legacy libdwarf-related " Alexis Berlemont
2014-10-23 21:56 ` [PATCH v2 12/14] perf kbuild: remove legacy script-related " Alexis Berlemont
2014-10-23 21:56 ` [PATCH v2 13/14] perf kbuild: final cosmetic changes Alexis Berlemont
2014-10-23 21:56 ` [PATCH v2 14/14] perf kbuild: add generated Kconfig build-test cases Alexis Berlemont
2014-09-23 13:13 ` [PATCH 01/15] kbuild: add support of custom paths for "auto.conf*" files Michal Marek
2014-10-23 21:44 ` Alexis Berlemont
2014-09-22 21:53 ` [PATCH 02/15] perf tools: Kbuild builtin source related fixies Alexis Berlemont
2014-09-22 21:53 ` [PATCH 03/15] perf tools: Kbuild " Alexis Berlemont
2014-09-22 21:53 ` [PATCH 04/15] perf tools: Add kbuild support into Makefile.kbuild Alexis Berlemont
2014-09-22 21:53 ` [PATCH 05/15] perf kbuild: remove Makefile.perf Alexis Berlemont
2014-09-22 21:53 ` [PATCH 06/15] perf kbuild: remove legacy tui/gui-related build variables Alexis Berlemont
2014-09-22 21:53 ` [PATCH 07/15] perf kbuild: remove legacy demangle-related " Alexis Berlemont
2014-09-22 21:53 ` [PATCH 08/15] perf kbuild: cross-compilation variables are now handled in Kconfig Alexis Berlemont
2014-09-22 21:53 ` [PATCH 09/15] perf kbuild: remove legacy misc build variables Alexis Berlemont
2014-09-22 21:53 ` [PATCH 10/15] perf kbuild: remove legacy libelf-related " Alexis Berlemont
2014-09-22 21:53 ` [PATCH 11/15] perf kbuild: remove legacy libdwarf-related " Alexis Berlemont
2014-09-22 21:53 ` [PATCH 12/15] perf kbuild: remove legacy script-related " Alexis Berlemont
2014-09-22 21:53 ` [PATCH 13/15] perf kbuild: final cosmetic changes Alexis Berlemont
2014-09-22 21:53 ` [PATCH 14/15] perf kbuild: add generated Kconfig build-test cases Alexis Berlemont
2014-09-22 21:53 ` [PATCH 15/15] perf: replace _BSD_SOURCE macro by _DEFAULT_SOURCE Alexis Berlemont
2014-09-28 22:15 ` Aaro Koskinen
2014-10-23 21:52 ` Alexis Berlemont
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141029230507.GA15701@marx-slim.home \
--to=alexis.berlemont@gmail.com \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@ghostprotocols.net \
--cc=acme@kernel.org \
--cc=bp@alien8.de \
--cc=cjashfor@linux.vnet.ibm.com \
--cc=dsahern@gmail.com \
--cc=eranian@google.com \
--cc=fweisbec@gmail.com \
--cc=jolsa@redhat.com \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=mingo@redhat.com \
--cc=mmarek@suse.cz \
--cc=namhyung@kernel.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®