From: Joonsoo Kim <iamjoonsoo.kim@lge.com>
To: Johannes Weiner <hannes@cmpxchg.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Michal Hocko <mhocko@suse.cz>,
Vladimir Davydov <vdavydov@parallels.com>,
Tejun Heo <tj@kernel.org>, David Miller <davem@davemloft.net>,
linux-mm@kvack.org, cgroups@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [patch 1/3] mm: embed the memcg pointer directly into struct page
Date: Mon, 3 Nov 2014 17:02:08 +0900 [thread overview]
Message-ID: <20141103080208.GA7052@js1304-P5Q-DELUXE> (raw)
In-Reply-To: <1414898156-4741-1-git-send-email-hannes@cmpxchg.org>
On Sat, Nov 01, 2014 at 11:15:54PM -0400, Johannes Weiner wrote:
> Memory cgroups used to have 5 per-page pointers. To allow users to
> disable that amount of overhead during runtime, those pointers were
> allocated in a separate array, with a translation layer between them
> and struct page.
Hello, Johannes.
I'd like to leave this translation layer.
Could you just disable that code with #ifdef until next user comes?
In our company, we uses PAGE_OWNER on mm tree which is the feature
saying who allocates the page. To use PAGE_OWNER needs modifying
struct page and then needs re-compile. This re-compile makes us difficult
to use this feature. So, we decide to implement run-time configurable
PAGE_OWNER through page_cgroup's translation layer code. Moreover, with
this infrastructure, I plan to implement some other debugging feature.
Because of my laziness, it didn't submitted to LKML. But, I will
submit it as soon as possible. If the code is removed, I would
copy-and-paste the code, but, it would cause lose of the history on
that code. So if possible, I'd like to leave that code now.
Thanks.
next prev parent reply other threads:[~2014-11-03 8:00 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-02 3:15 Johannes Weiner
2014-11-02 3:15 ` [patch 2/3] mm: page_cgroup: rename file to mm/swap_cgroup.c Johannes Weiner
2014-11-03 4:22 ` David Miller
2014-11-03 16:57 ` Michal Hocko
2014-11-03 17:30 ` Vladimir Davydov
2014-11-04 8:37 ` Kamezawa Hiroyuki
2014-11-02 3:15 ` [patch 3/3] mm: move page->mem_cgroup bad page handling into generic code Johannes Weiner
2014-11-03 4:23 ` David Miller
2014-11-03 16:58 ` Michal Hocko
2014-11-03 17:32 ` Vladimir Davydov
2014-11-03 18:27 ` [patch] mm: move page->mem_cgroup bad page handling into generic code fix Johannes Weiner
2014-11-03 20:10 ` David Miller
2014-11-04 8:39 ` [patch 3/3] mm: move page->mem_cgroup bad page handling into generic code Kamezawa Hiroyuki
2014-11-03 4:22 ` [patch 1/3] mm: embed the memcg pointer directly into struct page David Miller
2014-11-03 8:02 ` Joonsoo Kim [this message]
2014-11-03 15:09 ` Johannes Weiner
2014-11-03 16:42 ` David Miller
2014-11-03 17:02 ` Michal Hocko
2014-11-04 0:40 ` Joonsoo Kim
2014-11-03 16:51 ` Michal Hocko
2014-11-03 17:17 ` Michal Hocko
2014-11-03 17:30 ` Vladimir Davydov
2014-11-03 21:06 ` Kirill A. Shutemov
2014-11-03 21:36 ` Johannes Weiner
2014-11-03 21:52 ` Kirill A. Shutemov
2014-11-03 21:58 ` David Miller
2014-11-03 22:36 ` Johannes Weiner
2014-11-04 13:06 ` Michal Hocko
2014-11-04 13:48 ` Johannes Weiner
2014-11-04 14:50 ` Michal Hocko
2014-11-04 8:36 ` Kamezawa Hiroyuki
2014-11-04 13:27 ` Johannes Weiner
2014-11-04 13:41 ` Michal Hocko
2014-11-04 14:09 ` Johannes Weiner
2014-11-04 15:00 ` Michal Hocko
2014-11-04 17:46 ` Johannes Weiner
2014-11-04 16:34 ` David Miller
2014-11-06 18:55 ` Konstantin Khlebnikov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141103080208.GA7052@js1304-P5Q-DELUXE \
--to=iamjoonsoo.kim@lge.com \
--cc=akpm@linux-foundation.org \
--cc=cgroups@vger.kernel.org \
--cc=davem@davemloft.net \
--cc=hannes@cmpxchg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.cz \
--cc=tj@kernel.org \
--cc=vdavydov@parallels.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®