Re: [PATCH 4/7] perf tools: Enhance the thread stack to output call/return data

[Jiri Olsa <jolsa@redhat.com>]

On Thu, Oct 30, 2014 at 04:09:45PM +0200, Adrian Hunter wrote:
> Enhance the thread stack to output detailed information
> about paired calls and returns.
> 
> The enhanced processing consumes sample information via
> thread_stack__process() and outputs information about
> paired calls / returns via a call-back.  While the
> call-back makes it possible for the facility to be used
> by arbitrary tools, a subsequent patch will provide the
> information to Python scripting via the db-export
> interface.
> 
> An important part of the call/return information is the
> call path which provides a structure that defines a context
> sensitive call graph.
> 
> Note that there are now two ways to use the thread stack.
> For simply providing a call stack (like you would get
> from the perf record -g option) the interface consists of
> thread_stack__event() and thread_stack__sample().  Whereas
> the enhanced interface consists of call_return_processor__new()
> and thread_stack__process().

the interface seems pretty separated, with clear in and out values,
so it should be fairly easy to write automated tests for that ;-)

also given that there's no real user of this interface at the moment,
it'd be really nice to have ;-) anyway

Acked-by: Jiri Olsa <jolsa@kernel.org>

jirka