From: Oleg Nesterov <oleg@redhat.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Alexander Viro <viro@zeniv.linux.org.uk>,
Evan Teran <eteran@alum.rit.edu>,
Jan Kratochvil <jan.kratochvil@redhat.com>,
Pedro Alves <palves@redhat.com>,
Roland McGrath <roland@hack.frob.com>,
linux-kernel@vger.kernel.org
Subject: [PATCH 0/1] ptrace/x86: fix the TIF_FORCED_TF logic in handle_signal()
Date: Mon, 3 Nov 2014 21:12:56 +0100 [thread overview]
Message-ID: <20141103201256.GA5213@redhat.com> (raw)
Hello,
This is the very old bug initially reported by Evan in 2010, see
https://bugzilla.kernel.org/show_bug.cgi?id=16061
Somehow we forgot to fix it and now Pedro reports it again.
>From the changelog:
Note: in the longer term we should probably change setup_sigcontext()
to use get_flags() and then just remove this user_disable_single_step().
Yes, but this needs more changes. Lets start with more simple and
backportable fix. Also because I think that enable_single_step() and
the whole TIF_SINGLESTEP/TIF_FORCED_TF logic need some cleanups, but
I am not sure what we can do.
Oleg.
arch/x86/kernel/signal.c | 22 +++++++++++-----------
1 files changed, 11 insertions(+), 11 deletions(-)
next reply other threads:[~2014-11-03 20:12 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-03 20:12 Oleg Nesterov [this message]
2014-11-03 20:13 ` [PATCH 1/1] " Oleg Nesterov
2014-11-03 21:40 ` Pedro Alves
2014-11-04 23:55 ` Oleg Nesterov
2014-11-05 9:57 ` Pedro Alves
2014-11-27 23:21 ` Oleg Nesterov
2015-02-17 2:31 ` Andres Freund
2015-02-23 19:52 ` Oleg Nesterov
2015-01-06 16:18 ` [PATCH RESEND] " Oleg Nesterov
2015-02-23 19:53 ` [PATCH 2nd " Oleg Nesterov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141103201256.GA5213@redhat.com \
--to=oleg@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=eteran@alum.rit.edu \
--cc=jan.kratochvil@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=palves@redhat.com \
--cc=roland@hack.frob.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome