mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jonathan Corbet <corbet@lwn.net>
To: Fabian Frederick <fabf@skynet.be>
Cc: linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org
Subject: Re: [PATCH 1/1 net-next] ipv4: add kernel parameter tcpmhash_entries
Date: Tue, 4 Nov 2014 14:32:49 -0500	[thread overview]
Message-ID: <20141104143249.608c9fe4@lwn.net> (raw)
In-Reply-To: <1415128988-11665-1-git-send-email-fabf@skynet.be>

On Tue,  4 Nov 2014 20:23:08 +0100
Fabian Frederick <fabf@skynet.be> wrote:

> +			Set tcp_metrics_hash slot number.

So I'm not entirely clear on what that means.  Did you mean "Set the
number of tcp_metrics_hash slots"?  If so, that wording should be used.

Even in that case, though, what does this parameter actually *mean*?  If
we're going to document the parameter (and I think we should), it would
be good to say why a user might want to change it and what effects they
would expect to see.

Care to redo with that in mind?

Thanks,

jon

      reply	other threads:[~2014-11-04 19:32 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-04 19:23 Fabian Frederick
2014-11-04 19:32 ` Jonathan Corbet [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141104143249.608c9fe4@lwn.net \
    --to=corbet@lwn.net \
    --cc=fabf@skynet.be \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®