From: Al Viro <viro@ZenIV.linux.org.uk>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Ying Xue <ying.xue@windriver.com>,
linux-kernel@vger.kernel.org, jack@suse.cz
Subject: Re: [PATCH] acct: eliminate compile warning
Date: Wed, 5 Nov 2014 14:37:54 +0000 [thread overview]
Message-ID: <20141105143754.GR7996@ZenIV.linux.org.uk> (raw)
In-Reply-To: <20140826162501.7c05fa936e79c07927681bad@linux-foundation.org>
On Tue, Aug 26, 2014 at 04:25:01PM -0700, Andrew Morton wrote:
> We could actually do
>
> if (ACCT_VERSION == 3)
> ...
>
> in lots of places in acct.c. The code would be less ugly and
> compilation coverage testing would improve.
... too much. Finally got around to trying that; the problem is that
you can't do that in structure declarations. acct_t is either struct
acct, or struct acct_v3, and while we could split fill_ac() into
v3 and v1/v2 versions, it still doesn't sort everything out. So it
looks like that idea is no-go ;-/
prev parent reply other threads:[~2014-11-05 14:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-21 1:58 Ying Xue
2014-08-26 23:25 ` Andrew Morton
2014-11-05 14:37 ` Al Viro [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141105143754.GR7996@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=akpm@linux-foundation.org \
--cc=jack@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=ying.xue@windriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®