From: Sakari Ailus <sakari.ailus@iki.fi>
To: Hans Verkuil <hansverk@cisco.com>
Cc: Boris Brezillon <boris.brezillon@free-electrons.com>,
Mauro Carvalho Chehab <m.chehab@samsung.com>,
Hans Verkuil <hans.verkuil@cisco.com>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
linux-media@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, linux-api@vger.kernel.org,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
linux-doc@vger.kernel.org,
Guennadi Liakhovetski <g.liakhovetski@gmx.de>
Subject: Re: [PATCH 01/15] [media] Move mediabus format definition to a more standard place
Date: Wed, 5 Nov 2014 17:00:25 +0200 [thread overview]
Message-ID: <20141105150025.GS3136@valkosipuli.retiisi.org.uk> (raw)
In-Reply-To: <5458B407.6050701@cisco.com>
Hi,
On Tue, Nov 04, 2014 at 12:09:59PM +0100, Hans Verkuil wrote:
> Well, I gave two alternatives :-)
>
> Both are fine as far as I am concerned, but it would be nice to hear
> what others think.
In fact I think both are good options. :-)
I'd perhaps lean towards the latter, for it has the benefit of pushing to
use the new definitions and the old ones can be deprecated (and eventually
removed in year 2030 or so ;)).
Either way, preprocessor macros should be used instead of an enum since that
way it's possible to figure out at that phase whether something is defined
or not. There is for enums, too, but it results in a compilation error...
--
Regards,
Sakari Ailus
e-mail: sakari.ailus@iki.fi XMPP: sailus@retiisi.org.uk
next prev parent reply other threads:[~2014-11-05 15:02 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-04 9:54 [PATCH 00/15] [media] Make mediabus format subsystem neutral Boris Brezillon
2014-11-04 9:54 ` [PATCH 01/15] [media] Move mediabus format definition to a more standard place Boris Brezillon
2014-11-04 10:20 ` Hans Verkuil
2014-11-04 10:22 ` Hans Verkuil
2014-11-04 10:45 ` Boris Brezillon
2014-11-04 11:09 ` Hans Verkuil
2014-11-05 15:00 ` Sakari Ailus [this message]
2014-11-05 15:32 ` Boris Brezillon
2014-11-04 9:54 ` [PATCH 02/15] [media] v4l: Update subdev-formats doc with new MEDIA_BUS_FMT values Boris Brezillon
2014-11-05 14:57 ` Sakari Ailus
2014-11-05 15:01 ` Boris Brezillon
2014-11-04 9:54 ` [PATCH 03/15] [media] Make use of the new media_bus_format definitions Boris Brezillon
2014-11-05 15:19 ` Sakari Ailus
2014-11-04 9:54 ` [PATCH 04/15] [media] i2c: Make use of media_bus_format enum Boris Brezillon
2014-11-04 9:55 ` [PATCH 05/15] [media] pci: " Boris Brezillon
2014-11-04 9:55 ` [PATCH 06/15] [media] platform: " Boris Brezillon
2014-11-04 9:55 ` [PATCH 07/15] [media] usb: " Boris Brezillon
2014-11-04 9:55 ` [PATCH 08/15] staging: media: " Boris Brezillon
2014-11-04 9:55 ` [PATCH 09/15] gpu: ipu-v3: " Boris Brezillon
2014-11-04 9:55 ` [PATCH 10/15] [media] v4l: Forbid usage of V4L2_MBUS_FMT definitions inside the kernel Boris Brezillon
2014-11-04 9:55 ` [PATCH 11/15] [media] Deprecate v4l2_mbus_pixelcode Boris Brezillon
2014-11-05 15:08 ` Sakari Ailus
2014-11-05 15:15 ` Boris Brezillon
2014-11-05 15:19 ` Hans Verkuil
2014-11-05 15:30 ` Boris Brezillon
2014-11-05 15:34 ` Hans Verkuil
2014-11-05 15:22 ` Sakari Ailus
2014-11-04 9:55 ` [PATCH 12/15] [media] i2c: Replace v4l2-mediabus.h inclusion with v4l2-mbus.h Boris Brezillon
2014-11-04 9:55 ` [PATCH 13/15] gpu: ipu-v3: " Boris Brezillon
2014-11-04 9:55 ` [PATCH 14/15] [media] platform: " Boris Brezillon
2014-11-04 9:55 ` [PATCH 15/15] staging: media: " Boris Brezillon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141105150025.GS3136@valkosipuli.retiisi.org.uk \
--to=sakari.ailus@iki.fi \
--cc=boris.brezillon@free-electrons.com \
--cc=devel@driverdev.osuosl.org \
--cc=g.liakhovetski@gmx.de \
--cc=hans.verkuil@cisco.com \
--cc=hansverk@cisco.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-api@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=m.chehab@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®