From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752476AbaKERzg (ORCPT ); Wed, 5 Nov 2014 12:55:36 -0500 Received: from mail-qg0-f53.google.com ([209.85.192.53]:64220 "EHLO mail-qg0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751914AbaKERzb (ORCPT ); Wed, 5 Nov 2014 12:55:31 -0500 Date: Wed, 5 Nov 2014 12:55:27 -0500 From: Tejun Heo To: Michal Hocko Cc: "Rafael J. Wysocki" , Andrew Morton , Cong Wang , David Rientjes , Oleg Nesterov , LKML , linux-mm@kvack.org, Linux PM list Subject: Re: [PATCH 3/4] OOM, PM: OOM killed task shouldn't escape PM suspend Message-ID: <20141105175527.GH14386@htj.dyndns.org> References: <20141105124620.GB4527@dhcp22.suse.cz> <20141105130247.GA14386@htj.dyndns.org> <20141105133100.GC4527@dhcp22.suse.cz> <20141105134219.GD4527@dhcp22.suse.cz> <20141105154436.GB14386@htj.dyndns.org> <20141105160115.GA28226@dhcp22.suse.cz> <20141105162929.GD14386@htj.dyndns.org> <20141105163956.GD28226@dhcp22.suse.cz> <20141105165428.GF14386@htj.dyndns.org> <20141105174609.GE28226@dhcp22.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20141105174609.GE28226@dhcp22.suse.cz> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Nov 05, 2014 at 06:46:09PM +0100, Michal Hocko wrote: > Because out_of_memory can be called from mutliple paths. And > the only interesting one should be the page allocation path. > pagefault_out_of_memory is not interesting because it cannot happen for > the frozen task. Hmmm.... wouldn't that be broken by definition tho? So, if the oom killer is invoked from somewhere else than page allocation path, it would proceed ignoring the disabled setting and would race against PM freeze path all the same. Why are things broken at such basic levels? Something named oom_killer_disable does a lame attempt at it and not even that depending on who's calling. There probably is a history leading to the current situation but the level that things are broken at is too basic and baffling. :( -- tejun