From: Lee Jones <lee.jones@linaro.org>
To: Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>
Cc: Samuel Ortiz <sameo@linux.intel.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mfd: tc6393xb: prepare/unprepare clocks
Date: Thu, 6 Nov 2014 09:04:24 +0000 [thread overview]
Message-ID: <20141106090424.GB26543@x1> (raw)
In-Reply-To: <1415263958-16644-1-git-send-email-dbaryshkov@gmail.com>
On Thu, 06 Nov 2014, Dmitry Eremin-Solenikov wrote:
> Change clk_enable/disable() calls to clk_prepare_enable() and
> clk_disable_unrepapre().
>
> Signed-off-by: Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>
> ---
> drivers/mfd/tc6393xb.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
Applied, thanks.
> diff --git a/drivers/mfd/tc6393xb.c b/drivers/mfd/tc6393xb.c
> index 48579e5..abcb4eb 100644
> --- a/drivers/mfd/tc6393xb.c
> +++ b/drivers/mfd/tc6393xb.c
> @@ -665,7 +665,7 @@ static int tc6393xb_probe(struct platform_device *dev)
> goto err_ioremap;
> }
>
> - ret = clk_enable(tc6393xb->clk);
> + ret = clk_prepare_enable(tc6393xb->clk);
> if (ret)
> goto err_clk_enable;
>
> @@ -728,7 +728,7 @@ err_gpio_add:
> temp = gpiochip_remove(&tc6393xb->gpio);
> tcpd->disable(dev);
> err_enable:
> - clk_disable(tc6393xb->clk);
> + clk_disable_unprepare(tc6393xb->clk);
> err_clk_enable:
> iounmap(tc6393xb->scr);
> err_ioremap:
> @@ -764,7 +764,7 @@ static int tc6393xb_remove(struct platform_device *dev)
> }
>
> ret = tcpd->disable(dev);
> - clk_disable(tc6393xb->clk);
> + clk_disable_unprepare(tc6393xb->clk);
> iounmap(tc6393xb->scr);
> release_resource(&tc6393xb->rscr);
> clk_put(tc6393xb->clk);
> @@ -792,7 +792,7 @@ static int tc6393xb_suspend(struct platform_device *dev, pm_message_t state)
> ioread8(tc6393xb->scr + SCR_GPI_BCR(i));
> }
> ret = tcpd->suspend(dev);
> - clk_disable(tc6393xb->clk);
> + clk_disable_unprepare(tc6393xb->clk);
>
> return ret;
> }
> @@ -804,7 +804,7 @@ static int tc6393xb_resume(struct platform_device *dev)
> int ret;
> int i;
>
> - clk_enable(tc6393xb->clk);
> + clk_prepare_enable(tc6393xb->clk);
>
> ret = tcpd->resume(dev);
> if (ret)
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2014-11-06 9:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-06 8:52 Dmitry Eremin-Solenikov
2014-11-06 9:04 ` Lee Jones [this message]
2014-11-10 13:53 ` Lee Jones
2014-11-10 14:03 ` Dmitry Eremin-Solenikov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141106090424.GB26543@x1 \
--to=lee.jones@linaro.org \
--cc=dbaryshkov@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®