From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752373AbaKFKan (ORCPT ); Thu, 6 Nov 2014 05:30:43 -0500 Received: from mga03.intel.com ([134.134.136.65]:8802 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752344AbaKFKak (ORCPT ); Thu, 6 Nov 2014 05:30:40 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.07,325,1413270000"; d="scan'208";a="603363217" Date: Thu, 6 Nov 2014 12:30:33 +0200 From: Mika Westerberg To: Geert Uytterhoeven Cc: "Rafael J. Wysocki" , Alexandre Courbot , Linus Walleij , Bryan Wu , Richard Purdie , Ben Dooks , Kukjin Kim , Jason Cooper , Andrew Lunn , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , ACPI Devel Maling List , Linux-sh list Subject: Re: [PATCH] leds: leds-gpio: Convert gpio_blink_set() to use GPIO descriptors Message-ID: <20141106103033.GK1618@lahna.fi.intel.com> References: <1414755658-96293-1-git-send-email-mika.westerberg@linux.intel.com> <545843B1.3020101@nvidia.com> <2455157.3p7mHhT8im@vostro.rjw.lan> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Nov 06, 2014 at 10:52:35AM +0100, Geert Uytterhoeven wrote: > Hi Mika, Rafael, > > On Tue, Nov 4, 2014 at 11:50 PM, Rafael J. Wysocki wrote: > > On Tuesday, November 04, 2014 12:10:41 PM Alexandre Courbot wrote: > >> On 10/31/2014 08:40 PM, Mika Westerberg wrote: > >> > Commit 21f2aae91e902aad ("leds: leds-gpio: Add support for GPIO > >> > descriptors") already converted most of the driver to use GPIO descriptors. > >> > What is still missing is the platform specific hook gpio_blink_set() and > >> > board files which pass legacy GPIO numbers to this driver in platform data. > >> > > >> > In this patch we handle the former and convert gpio_blink_set() to take > >> > GPIO descriptor instead. In order to do this we convert the existing four > >> > users to accept GPIO descriptor and translate it to legacy GPIO number in > >> > the platform code. This effectively "pushes" legacy GPIO number usage from > >> > the driver to platforms. > >> > > >> > Also add comment to the remaining block describing that it is legacy code > >> > path and we are getting rid of it eventually. > >> > > >> > Suggested-by: Linus Walleij > >> > Signed-off-by: Mika Westerberg > >> > >> Acked-by: Alexandre Courbot > > > > Patch applied, thanks everyone! > > "leds: leds-gpio: Add support for GPIO descriptors" broke leds-gpio on > non-DT platforms for me: > > gpiod_direction_output: invalid GPIO > leds-gpio: probe of leds-gpio failed with error -22 > > (desc is NULL in gpiod_direction_output()). > > DT shmobile reference/multi-platform are fine. > > I noticed the hard way, as I wanted to add some LEDs to a new platform, > but couldn't get it work. It turned out it also had stopped working on > r8a7740/armadillo-legacy, so I started bisecting... Which board file that is? There is a bug that gpio_to_desc() returns NULL instead if ERR_PTR() in that patch but I wonder why gpio_is_valid() and devm_gpio_request_one() do not complain about that prior.