From: Peter Zijlstra <peterz@infradead.org>
To: Namhyung Kim <namhyung@kernel.org>
Cc: Arnaldo Carvalho de Melo <acme@kernel.org>,
Ingo Molnar <mingo@kernel.org>, Paul Mackerras <paulus@samba.org>,
Namhyung Kim <namhyung.kim@lge.com>,
LKML <linux-kernel@vger.kernel.org>, Jiri Olsa <jolsa@redhat.com>,
Adrian Hunter <adrian.hunter@intel.com>,
David Ahern <dsahern@gmail.com>
Subject: Re: [PATCH 1/3] perf tools: Allow vmlinux to fallback to kallsyms on NO_LIBELF=1
Date: Fri, 7 Nov 2014 18:37:18 +0100 [thread overview]
Message-ID: <20141107173718.GD29390@twins.programming.kicks-ass.net> (raw)
In-Reply-To: <1415372259.1648.51.camel@leonhard>
On Fri, Nov 07, 2014 at 11:57:39PM +0900, Namhyung Kim wrote:
> > Why does this live in the minimal implementation; should we not always
> > discard ELF files with 0 symbols?
> >
> > Suppose I have a vmlinux but removed all symbols from it; I want it to
> > fall back to kallsyms too.
>
> I'm not sure I understood what you said correctly. With this change,
> dso__load_kernel_sym() always ends up calling dso__load_kallsyms() since
> dso__load_vmlinux() will always return 0;
>
> So I think you'll fall back to kallsyms even though you have a vmlinux
> with symbol. This makes dso__load_sym() in the patch 2/3 simpler IMHO.
But why have it specific to the minimal elf thing? Why not discard any
DSO with 0 symbols and try the next option to acquire symbols?
next prev parent reply other threads:[~2014-11-07 17:37 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-07 5:20 Namhyung Kim
2014-11-07 5:20 ` [PATCH 2/3] perf symbol: Implement a very simple ELF symbol parser Namhyung Kim
2014-11-07 15:26 ` Arnaldo Carvalho de Melo
2014-11-10 6:36 ` Namhyung Kim
2014-11-10 12:09 ` Arnaldo Carvalho de Melo
2014-11-17 2:31 ` Namhyung Kim
2014-11-07 5:20 ` [PATCH 3/3] perf tools: Clean up libelf feature support code Namhyung Kim
2014-11-20 7:36 ` [tip:perf/core] " tip-bot for Namhyung Kim
2014-11-07 8:27 ` [PATCH 1/3] perf tools: Allow vmlinux to fallback to kallsyms on NO_LIBELF=1 Peter Zijlstra
2014-11-07 14:57 ` Namhyung Kim
2014-11-07 17:37 ` Peter Zijlstra [this message]
2014-11-10 6:33 ` Namhyung Kim
2014-11-10 12:11 ` Peter Zijlstra
2014-11-11 4:24 ` Namhyung Kim
2014-11-11 10:27 ` Peter Zijlstra
2014-11-11 13:03 ` Arnaldo Carvalho de Melo
2014-11-11 14:02 ` Arnaldo Carvalho de Melo
2014-11-11 17:19 ` Peter Zijlstra
2014-11-20 7:37 ` [tip:perf/core] perf symbols: Fallback to kallsyms when using the minimal 'ELF' loader tip-bot for Arnaldo Carvalho de Melo
2014-11-11 13:02 ` [PATCH 1/3] perf tools: Allow vmlinux to fallback to kallsyms on NO_LIBELF=1 Arnaldo Carvalho de Melo
2014-11-17 1:55 ` Namhyung Kim
2014-11-07 15:21 ` David Ahern
2014-11-10 7:40 ` Namhyung Kim
2014-11-10 14:20 ` David Ahern
2014-11-07 15:29 ` Arnaldo Carvalho de Melo
2014-11-10 6:53 ` Namhyung Kim
2014-11-10 12:11 ` Arnaldo Carvalho de Melo
2014-11-17 2:04 ` Namhyung Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141107173718.GD29390@twins.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=dsahern@gmail.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=namhyung.kim@lge.com \
--cc=namhyung@kernel.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome