Re: [PATCH 1/2] spi: add support for DLN-2 USB-SPI adapter

[Mark Brown <broonie@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 852 bytes --]

On Fri, Nov 07, 2014 at 02:45:13PM +0200, Laurentiu Palcu wrote:

> +static int dln2_spi_transfer_one_message(struct spi_master *master,
> +					 struct spi_message *msg)

It's a bit sad not to do transfer_one() but it's reasonable not to
because of the fun way /CS is being set.

> +	ret = dln2_spi_get_speed_range(dln2,
> +					   &master->min_speed_hz,
> +					   &master->max_speed_hz);

Strange indentation here.

> +static int dln2_spi_remove(struct platform_device *pdev)
> +{
> +	struct spi_master *master = spi_master_get(platform_get_drvdata(pdev));
> +	struct dln2_spi *dln2 = spi_master_get_devdata(master);
> +
> +	if (dln2_spi_enable(dln2, false) < 0)
> +		dev_err(&pdev->dev, "Failed to disable SPI module\n");
> +
> +	spi_master_put(master);

You shouldn't need this _put(), it's defeating the purpose of having the
devm_ registration.

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]