mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: luto@amacapital.net
Cc: tglx@linutronix.de, linux-kernel@vger.kernel.org,
	akpm@linux-foundation.org, linux-arch@vger.kernel.org,
	viro@zeniv.linux.org.uk, richard.weinberger@gmail.com,
	hpa@zytor.com, mingo@kernel.org, keescook@chromium.org
Subject: Re: [PATCH v2] all arches, signal: Move restart_block to struct task_struct
Date: Mon, 10 Nov 2014 21:13:19 -0500 (EST)	[thread overview]
Message-ID: <20141110.211319.1983610686941713044.davem@davemloft.net> (raw)
In-Reply-To: <CALCETrWtBCFXzwCAh8fpeFv-EvPxYW20oRmFk1iCYwUvpft=Rw@mail.gmail.com>

From: Andy Lutomirski <luto@amacapital.net>
Date: Mon, 10 Nov 2014 14:03:23 -0800

> On Wed, Oct 29, 2014 at 11:12 AM, Thomas Gleixner <tglx@linutronix.de> wrote:
>> On Wed, 29 Oct 2014, Andy Lutomirski wrote:
>>
>>> If an attacker can cause a controlled kernel stack overflow,
>>> overwriting the restart block is a very juicy exploit target.
>>> Moving the restart block to struct task_struct prevents this
>>> exploit.
>>>
>>> Note that there are other fields in thread_info that are also easy
>>> targets, at least on some architectures.
>>>
>>> It's also a decent simplification, since the restart code is more or
>>> less identical on all architectures.
>>
>> I think that's the most important change. Moving common stuff into
>> common code. The side effect of slightly reducing the attack surface
>> is nice, but as Al pointed out not really the big win here.
> 
> Having gotten exactly zero feedback from any arch maintainer outside
> of x86, am I supposed to pester people further?

No objections wrt. sparc and if things break I'll help fix it.

  reply	other threads:[~2014-11-11  2:13 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-29 17:36 Andy Lutomirski
2014-10-29 18:12 ` Thomas Gleixner
2014-11-10 22:03   ` Andy Lutomirski
2014-11-11  2:13     ` David Miller [this message]
2014-11-11 10:52       ` Richard Weinberger
2014-12-01 14:55         ` Andy Lutomirski
2014-12-03 23:37           ` Andrew Morton
2014-12-03 23:38             ` Andy Lutomirski
2014-12-03 23:53               ` Andrew Morton
2014-12-04  0:01                 ` Andy Lutomirski
2014-12-05 11:13           ` Chuck Ebbert
2014-12-08 22:51             ` Andy Lutomirski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141110.211319.1983610686941713044.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=akpm@linux-foundation.org \
    --cc=hpa@zytor.com \
    --cc=keescook@chromium.org \
    --cc=linux-arch@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luto@amacapital.net \
    --cc=mingo@kernel.org \
    --cc=richard.weinberger@gmail.com \
    --cc=tglx@linutronix.de \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®